feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Use handleGuiChanged more consistently in aspect implementations

Browse Source 
Change-Id: I53eb3416b27dca45bd30860f1fb0ec674c98240e
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-18 08:48:01 +02:00
parent c7cf450bd8
commit 2a31f17354
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libs/utils/aspects.cpp
View File

@@ -1860,11 +1860,8 @@ void IntegerAspect::addToLayout(Layouting::LayoutItem &parent)
int(d->m_maximumValue.value() / d->m_displayScaleFactor)); int(d->m_maximumValue.value() / d->m_displayScaleFactor));
d->m_spinBox->setValue(int(value() / d->m_displayScaleFactor)); // Must happen after setRange() d->m_spinBox->setValue(int(value() / d->m_displayScaleFactor)); // Must happen after setRange()
addLabeledItem(parent, d->m_spinBox); addLabeledItem(parent, d->m_spinBox);
connect(d->m_spinBox.data(), &QSpinBox::valueChanged,
if (isAutoApply()) { this, &IntegerAspect::handleGuiChanged);
connect(d->m_spinBox.data(), &QSpinBox::valueChanged,
this, [this] { setValue(d->m_spinBox->value() * d->m_displayScaleFactor); });
}
} }
void IntegerAspect::guiToBuffer() void IntegerAspect::guiToBuffer()
@@ -1962,11 +1959,8 @@ void DoubleAspect::addToLayout(LayoutItem &builder)
d->m_spinBox->setRange(d->m_minimumValue.value(), d->m_maximumValue.value()); d->m_spinBox->setRange(d->m_minimumValue.value(), d->m_maximumValue.value());
bufferToGui(); // Must happen after setRange()! bufferToGui(); // Must happen after setRange()!
addLabeledItem(builder, d->m_spinBox); addLabeledItem(builder, d->m_spinBox);
connect(d->m_spinBox.data(), &QDoubleSpinBox::valueChanged,
if (isAutoApply()) { this, &DoubleAspect::handleGuiChanged);
connect(d->m_spinBox.data(), &QDoubleSpinBox::valueChanged,
this, [this] { setValue(d->m_spinBox->value()); });
}
} }
void DoubleAspect::guiToBuffer() void DoubleAspect::guiToBuffer()