feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Send start failed if no ProcessInterface

Browse Source 
Change-Id: I38cdce9812bcec3240e3fb4f30a1dd266a5515e9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-10-11 13:16:02 +02:00
parent b1b83c5c5e
commit 2a510011f1
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/libs/utils/process.cpp
View File

@@ -1251,7 +1251,19 @@ void Process::start()
} else { } else {
processImpl = d->createProcessInterface(); processImpl = d->createProcessInterface();
} }
QTC_ASSERT(processImpl, return);
if (!processImpl) {
// This happens if a device does not implement the createProcessInterface() function.
d->m_result = ProcessResult::StartFailed;
d->m_resultData.m_exitCode = 255;
d->m_resultData.m_exitStatus = QProcess::CrashExit;
d->m_resultData.m_errorString = Tr::tr("Failed to create process interface for \"%1\"")
.arg(d->m_setup.m_commandLine.toUserOutput());
d->m_resultData.m_error = QProcess::FailedToStart;
d->emitGuardedSignal(&Process::done);
return;
}
d->setProcessInterface(processImpl); d->setProcessInterface(processImpl);
d->m_state = QProcess::Starting; d->m_state = QProcess::Starting;
d->m_process->m_setup = d->m_setup; d->m_process->m_setup = d->m_setup;

1
src/plugins/projectexplorer/devicesupport/idevice.cpp
View File

@@ -290,7 +290,6 @@ FilePath IDevice::searchExecutable(const QString &fileName, const FilePaths &dir
ProcessInterface *IDevice::createProcessInterface() const ProcessInterface *IDevice::createProcessInterface() const
{ {
QTC_CHECK(false);
return nullptr; return nullptr;
} }