From 2a7a90823362602ad0badc261773ff08c237ab2d Mon Sep 17 00:00:00 2001
From: Alessandro Portale <alessandro.portale@qt.io>
Date: Tue, 19 Nov 2019 17:27:32 +0100
Subject: [PATCH] McuSupport: Only (re-)generate kits when on Mcu options page

... less surprises, like for example user is on the Kits page, edits an
existing kit, and that gets overwritten when pressing "Apply"

Change-Id: I2d936b757cb5c891a087854805fa2f056834185f
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/mcusupport/mcusupportoptionspage.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/plugins/mcusupport/mcusupportoptionspage.cpp b/src/plugins/mcusupport/mcusupportoptionspage.cpp
index 06bb9a86e63..c0d1c42afc7 100644
--- a/src/plugins/mcusupport/mcusupportoptionspage.cpp
+++ b/src/plugins/mcusupport/mcusupportoptionspage.cpp
@@ -168,6 +168,9 @@ void McuSupportOptionsPage::apply()
     QTC_ASSERT(m_options->armGccPackage, return);
     QTC_ASSERT(m_options->qtForMCUsSdkPackage, return);
 
+    if (!widget()->isVisible())
+        return; // Only create/overwrite kits when this option page is shown
+
     const McuTarget *mcuTarget = m_widget->currentMcuTarget();
     if (!mcuTarget)
         return;