diff --git a/src/plugins/android/androidconfigurations.cpp b/src/plugins/android/androidconfigurations.cpp index 0d9b1a23289..00bb8b68c11 100644 --- a/src/plugins/android/androidconfigurations.cpp +++ b/src/plugins/android/androidconfigurations.cpp @@ -951,7 +951,7 @@ static QVariant findOrRegisterDebugger(ToolChain *tc) // check if the debugger is already registered, but ignoring the display name const Debugger::DebuggerItem *existing = Debugger::DebuggerItemManager::findByCommand(command); if (existing && existing->engineType() == Debugger::GdbEngineType && existing->isAutoDetected() - && existing->abis() == QList{tc->targetAbi()}) + && existing->abis() == Abis{tc->targetAbi()}) return existing->id(); // debugger not found, register a new one Debugger::DebuggerItem debugger; @@ -997,7 +997,7 @@ void AndroidConfigurations::updateAutomaticKitList() return v->type() == Constants::ANDROIDQT; }); for (const QtSupport::BaseQtVersion *qtVersion : qtVersions) { - const QList qtAbis = qtVersion->qtAbis(); + const Abis qtAbis = qtVersion->qtAbis(); if (qtAbis.empty()) continue; qtVersionsForArch[qtAbis.first()].append(qtVersion); diff --git a/src/plugins/android/androidqtversion.cpp b/src/plugins/android/androidqtversion.cpp index e545d131cf1..eff95c3f040 100644 --- a/src/plugins/android/androidqtversion.cpp +++ b/src/plugins/android/androidqtversion.cpp @@ -69,9 +69,9 @@ QString AndroidQtVersion::invalidReason() const return tmp; } -QList AndroidQtVersion::detectQtAbis() const +Abis AndroidQtVersion::detectQtAbis() const { - QList abis = BaseQtVersion::detectQtAbis(); + Abis abis = BaseQtVersion::detectQtAbis(); for (int i = 0; i < abis.count(); ++i) { abis[i] = Abi(abis.at(i).architecture(), abis.at(i).os(), diff --git a/src/plugins/android/androidqtversion.h b/src/plugins/android/androidqtversion.h index 4476aea6c70..519d702eade 100644 --- a/src/plugins/android/androidqtversion.h +++ b/src/plugins/android/androidqtversion.h @@ -43,7 +43,7 @@ public: bool isValid() const override; QString invalidReason() const override; - QList detectQtAbis() const override; + ProjectExplorer::Abis detectQtAbis() const override; void addToEnvironment(const ProjectExplorer::Kit *k, Utils::Environment &env) const override; Utils::Environment qmakeRunEnvironment() const override; diff --git a/src/plugins/debugger/debuggeritem.cpp b/src/plugins/debugger/debuggeritem.cpp index 0acf32b688c..2c073b1d54f 100644 --- a/src/plugins/debugger/debuggeritem.cpp +++ b/src/plugins/debugger/debuggeritem.cpp @@ -343,7 +343,7 @@ void DebuggerItem::setVersion(const QString &version) m_version = version; } -void DebuggerItem::setAbis(const QList &abis) +void DebuggerItem::setAbis(const Abis &abis) { m_abis = abis; } diff --git a/src/plugins/debugger/debuggeritem.h b/src/plugins/debugger/debuggeritem.h index 20f141600b5..c065700d96e 100644 --- a/src/plugins/debugger/debuggeritem.h +++ b/src/plugins/debugger/debuggeritem.h @@ -81,8 +81,8 @@ public: QString version() const; void setVersion(const QString &version); - const QList &abis() const { return m_abis; } - void setAbis(const QList &abis); + const ProjectExplorer::Abis &abis() const { return m_abis; } + void setAbis(const ProjectExplorer::Abis &abis); void setAbi(const ProjectExplorer::Abi &abi); enum MatchLevel { DoesNotMatch, MatchesSomewhat, MatchesWell, MatchesPerfectly, MatchesPerfectlyInPath }; @@ -113,7 +113,7 @@ private: Utils::FileName m_workingDirectory; bool m_isAutoDetected = false; QString m_version; - QList m_abis; + ProjectExplorer::Abis m_abis; QDateTime m_lastModified; friend class Internal::DebuggerConfigWidget; diff --git a/src/plugins/debugger/debuggeritemmanager.cpp b/src/plugins/debugger/debuggeritemmanager.cpp index 096262a783f..da5ceae2fe4 100644 --- a/src/plugins/debugger/debuggeritemmanager.cpp +++ b/src/plugins/debugger/debuggeritemmanager.cpp @@ -350,7 +350,7 @@ DebuggerItem DebuggerItemConfigWidget::item() const item.setCommand(m_binaryChooser->fileName()); item.setWorkingDirectory(m_workingDirectoryChooser->fileName()); item.setAutoDetected(m_autodetected); - QList abiList; + ProjectExplorer::Abis abiList; foreach (const QString &a, m_abis->text().split(QRegExp("[^A-Za-z0-9-_]+"))) { if (a.isNull()) continue; diff --git a/src/plugins/debugger/debuggerplugin.cpp b/src/plugins/debugger/debuggerplugin.cpp index dd0149fe4f4..2282a9dfe80 100644 --- a/src/plugins/debugger/debuggerplugin.cpp +++ b/src/plugins/debugger/debuggerplugin.cpp @@ -807,7 +807,7 @@ static QString msgParameterMissing(const QString &a) return DebuggerPlugin::tr("Option \"%1\" is missing the parameter.").arg(a); } -static Kit *guessKitFromAbis(const QList &abis) +static Kit *guessKitFromAbis(const Abis &abis) { Kit *kit = nullptr; @@ -2620,8 +2620,8 @@ void DebuggerUnitTests::testDebuggerMatching() auto expectedLevel = static_cast(result); - QList debuggerAbis; - foreach (const QString &abi, debugger) + Abis debuggerAbis; + for (const QString &abi : qAsConst(debugger)) debuggerAbis << Abi::fromString(abi); DebuggerItem item; diff --git a/src/plugins/ios/iosqtversion.cpp b/src/plugins/ios/iosqtversion.cpp index 78101fa55b7..e508c53cfe0 100644 --- a/src/plugins/ios/iosqtversion.cpp +++ b/src/plugins/ios/iosqtversion.cpp @@ -59,9 +59,9 @@ QString IosQtVersion::invalidReason() const return tmp; } -QList IosQtVersion::detectQtAbis() const +Abis IosQtVersion::detectQtAbis() const { - QList abis = BaseQtVersion::detectQtAbis(); + Abis abis = BaseQtVersion::detectQtAbis(); for (int i = 0; i < abis.count(); ++i) { abis[i] = Abi(abis.at(i).architecture(), abis.at(i).os(), diff --git a/src/plugins/ios/iosqtversion.h b/src/plugins/ios/iosqtversion.h index 3da34918d89..fa119d2f6f5 100644 --- a/src/plugins/ios/iosqtversion.h +++ b/src/plugins/ios/iosqtversion.h @@ -43,7 +43,7 @@ public: bool isValid() const override; QString invalidReason() const override; - QList detectQtAbis() const override; + ProjectExplorer::Abis detectQtAbis() const override; void addToEnvironment(const ProjectExplorer::Kit *k, Utils::Environment &env) const override; diff --git a/src/plugins/projectexplorer/abi.cpp b/src/plugins/projectexplorer/abi.cpp index 07647bdbda9..a719bc3ee01 100644 --- a/src/plugins/projectexplorer/abi.cpp +++ b/src/plugins/projectexplorer/abi.cpp @@ -219,9 +219,9 @@ static Abi macAbiForCpu(quint32 type) { } } -static QList parseCoffHeader(const QByteArray &data) +static Abis parseCoffHeader(const QByteArray &data) { - QList result; + Abis result; if (data.size() < 20) return result; @@ -305,9 +305,9 @@ static QList parseCoffHeader(const QByteArray &data) return result; } -static QList abiOf(const QByteArray &data) +static Abis abiOf(const QByteArray &data) { - QList result; + Abis result; if (data.size() <= 8) return result; @@ -983,9 +983,9 @@ Abi Abi::hostAbi() } //! Extract available ABIs from a binary using heuristics. -QList Abi::abisOfBinary(const Utils::FileName &path) +Abis Abi::abisOfBinary(const Utils::FileName &path) { - QList tmp; + Abis tmp; if (path.isEmpty()) return tmp; @@ -1038,8 +1038,8 @@ QList Abi::abisOfBinary(const Utils::FileName &path) f.close(); // Remove duplicates: - QList result; - foreach (const Abi &a, tmp) { + Abis result; + for (const Abi &a : qAsConst(tmp)) { if (!result.contains(a)) result.append(a); } @@ -1233,7 +1233,7 @@ void ProjectExplorer::ProjectExplorerPlugin::testAbiOfBinary() QFETCH(QString, file); QFETCH(QStringList, abis); - QList result = Abi::abisOfBinary(Utils::FileName::fromString(file)); + const Abis result = Abi::abisOfBinary(Utils::FileName::fromString(file)); QCOMPARE(result.count(), abis.count()); for (int i = 0; i < abis.count(); ++i) QCOMPARE(result.at(i).toString(), abis.at(i)); diff --git a/src/plugins/projectexplorer/abi.h b/src/plugins/projectexplorer/abi.h index a53cc355ebd..38eeeb8a5f4 100644 --- a/src/plugins/projectexplorer/abi.h +++ b/src/plugins/projectexplorer/abi.h @@ -42,6 +42,9 @@ namespace ProjectExplorer { // ABI (documentation inside) // -------------------------------------------------------------------------- +class Abi; +using Abis = QList; + class PROJECTEXPLORER_EXPORT Abi { public: @@ -157,7 +160,7 @@ public: static Abi fromString(const QString &abiString); static Abi hostAbi(); - static QList abisOfBinary(const Utils::FileName &path); + static Abis abisOfBinary(const Utils::FileName &path); private: diff --git a/src/plugins/projectexplorer/abiwidget.cpp b/src/plugins/projectexplorer/abiwidget.cpp index 7135f2891af..5df9a3ee059 100644 --- a/src/plugins/projectexplorer/abiwidget.cpp +++ b/src/plugins/projectexplorer/abiwidget.cpp @@ -151,12 +151,12 @@ AbiWidget::AbiWidget(QWidget *parent) : QWidget(parent), layout->setStretchFactor(d->m_abi, 1); - setAbis(QList(), Abi::hostAbi()); + setAbis(Abis(), Abi::hostAbi()); } AbiWidget::~AbiWidget() = default; -static Abi selectAbi(const Abi ¤t, const QList &abiList) +static Abi selectAbi(const Abi ¤t, const Abis &abiList) { if (!current.isNull()) return current; @@ -165,7 +165,7 @@ static Abi selectAbi(const Abi ¤t, const QList &abiList) return Abi::hostAbi(); } -void AbiWidget::setAbis(const QList &abiList, const Abi ¤tAbi) +void AbiWidget::setAbis(const Abis &abiList, const Abi ¤tAbi) { const Abi defaultAbi = selectAbi(currentAbi, abiList); { @@ -191,9 +191,9 @@ void AbiWidget::setAbis(const QList &abiList, const Abi ¤tAbi) emitAbiChanged(defaultAbi); } -QList AbiWidget::supportedAbis() const +Abis AbiWidget::supportedAbis() const { - QList result; + Abis result; result.reserve(d->m_abi->count()); for (int i = 1; i < d->m_abi->count(); ++i) result << Abi::fromString(d->m_abi->itemData(i).toString()); diff --git a/src/plugins/projectexplorer/abiwidget.h b/src/plugins/projectexplorer/abiwidget.h index b8a64dd05c0..6cd6699ce73 100644 --- a/src/plugins/projectexplorer/abiwidget.h +++ b/src/plugins/projectexplorer/abiwidget.h @@ -27,12 +27,13 @@ #include "projectexplorer_export.h" +#include "abi.h" + #include #include namespace ProjectExplorer { -class Abi; namespace Internal { class AbiWidgetPrivate; } @@ -48,9 +49,9 @@ public: AbiWidget(QWidget *parent = nullptr); ~AbiWidget() override; - void setAbis(const QList &, const Abi ¤tAbi); + void setAbis(const ProjectExplorer::Abis &, const Abi ¤tAbi); - QList supportedAbis() const; + Abis supportedAbis() const; bool isCustomAbi() const; Abi currentAbi() const; diff --git a/src/plugins/projectexplorer/customtoolchain.cpp b/src/plugins/projectexplorer/customtoolchain.cpp index 0d898657161..e2f0efc78d9 100644 --- a/src/plugins/projectexplorer/customtoolchain.cpp +++ b/src/plugins/projectexplorer/customtoolchain.cpp @@ -598,7 +598,7 @@ void CustomToolChainConfigWidget::setFromToolchain() auto tc = static_cast(toolChain()); m_compilerCommand->setFileName(tc->compilerCommand()); m_makeCommand->setFileName(tc->makeCommand(Environment())); - m_abiWidget->setAbis(QList(), tc->targetAbi()); + m_abiWidget->setAbis(Abis(), tc->targetAbi()); const QStringList macroLines = Utils::transform(tc->rawPredefinedMacros(), [](const Macro &m) { return QString::fromUtf8(m.toKeyValue(QByteArray())); }); diff --git a/src/plugins/projectexplorer/gcctoolchain.cpp b/src/plugins/projectexplorer/gcctoolchain.cpp index 6ecf8e86456..912d7d53812 100644 --- a/src/plugins/projectexplorer/gcctoolchain.cpp +++ b/src/plugins/projectexplorer/gcctoolchain.cpp @@ -167,9 +167,9 @@ HeaderPaths GccToolChain::gccHeaderPaths(const FileName &gcc, const QStringList return builtInHeaderPaths; } -static QList guessGccAbi(const QString &m, const ProjectExplorer::Macros ¯os) +static Abis guessGccAbi(const QString &m, const ProjectExplorer::Macros ¯os) { - QList abiList; + Abis abiList; Abi guessed = Abi::abiFromTargetTriplet(m); if (guessed.isNull()) @@ -249,12 +249,12 @@ void GccToolChain::setCompilerCommand(const FileName &path) toolChainUpdated(); } -void GccToolChain::setSupportedAbis(const QList &m_abis) +void GccToolChain::setSupportedAbis(const Abis &abis) { - if (m_supportedAbis == m_abis) + if (m_supportedAbis == abis) return; - m_supportedAbis = m_abis; + m_supportedAbis = abis; toolChainUpdated(); } @@ -322,7 +322,7 @@ void GccToolChain::setTargetAbi(const Abi &abi) toolChainUpdated(); } -QList GccToolChain::supportedAbis() const +Abis GccToolChain::supportedAbis() const { return m_supportedAbis; } @@ -1151,7 +1151,7 @@ void GccToolChainConfigWidget::handleCompilerCommandChange() Abi currentAbi = m_abiWidget->currentAbi(); bool customAbi = m_abiWidget->isCustomAbi() && m_abiWidget->isEnabled(); FileName path = m_compilerCommand->fileName(); - QList abiList; + Abis abiList; if (!path.isEmpty()) { QFileInfo fi(path.toFileInfo()); @@ -1941,7 +1941,7 @@ void ProjectExplorerPlugin::testGccAbiGuessing() QFETCH(QByteArray, macros); QFETCH(QStringList, abiList); - QList al = guessGccAbi(input, ProjectExplorer::Macro::toMacros(macros)); + const Abis al = guessGccAbi(input, ProjectExplorer::Macro::toMacros(macros)); QCOMPARE(al.count(), abiList.count()); for (int i = 0; i < al.count(); ++i) QCOMPARE(al.at(i).toString(), abiList.at(i)); diff --git a/src/plugins/projectexplorer/gcctoolchain.h b/src/plugins/projectexplorer/gcctoolchain.h index 99d61e2d89e..44dbf84186a 100644 --- a/src/plugins/projectexplorer/gcctoolchain.h +++ b/src/plugins/projectexplorer/gcctoolchain.h @@ -72,7 +72,7 @@ public: Abi targetAbi() const override; QString originalTargetTriple() const override; QString version() const; - QList supportedAbis() const override; + Abis supportedAbis() const override; void setTargetAbi(const Abi &); bool isValid() const override; @@ -112,13 +112,12 @@ public: class DetectedAbisResult { public: DetectedAbisResult() = default; - DetectedAbisResult(const QList &supportedAbis, - const QString &originalTargetTriple = QString()) : + DetectedAbisResult(const Abis &supportedAbis, const QString &originalTargetTriple = {}) : supportedAbis(supportedAbis), originalTargetTriple(originalTargetTriple) { } - QList supportedAbis; + Abis supportedAbis; QString originalTargetTriple; }; @@ -127,7 +126,7 @@ protected: using GccCache = QVector; void setCompilerCommand(const Utils::FileName &path); - void setSupportedAbis(const QList &m_abis); + void setSupportedAbis(const Abis &abis); void setOriginalTargetTriple(const QString &targetTriple); void setMacroCache(const QStringList &allCxxflags, const Macros ¯oCache) const; Macros macroCache(const QStringList &allCxxflags) const; @@ -194,7 +193,7 @@ protected: private: Abi m_targetAbi; - mutable QList m_supportedAbis; + mutable Abis m_supportedAbis; mutable QString m_originalTargetTriple; mutable HeaderPaths m_headerPaths; mutable QString m_version; diff --git a/src/plugins/projectexplorer/msvctoolchain.cpp b/src/plugins/projectexplorer/msvctoolchain.cpp index e4db2f48c50..446e2445b7e 100644 --- a/src/plugins/projectexplorer/msvctoolchain.cpp +++ b/src/plugins/projectexplorer/msvctoolchain.cpp @@ -776,7 +776,7 @@ void MsvcToolChain::updateEnvironmentModifications(QList void MsvcToolChain::detectInstalledAbis() { - static QMap> abiCache; + static QMap abiCache; const QString vcVarsBase = QDir::fromNativeSeparators(m_vcvarsBat).left(m_vcvarsBat.lastIndexOf('/')); if (abiCache.contains(vcVarsBase)) { @@ -913,7 +913,7 @@ Abi MsvcToolChain::targetAbi() const return m_abi; } -QList MsvcToolChain::supportedAbis() const +Abis MsvcToolChain::supportedAbis() const { return m_supportedAbis; } diff --git a/src/plugins/projectexplorer/msvctoolchain.h b/src/plugins/projectexplorer/msvctoolchain.h index 02177e4a655..8bd8b28bba9 100644 --- a/src/plugins/projectexplorer/msvctoolchain.h +++ b/src/plugins/projectexplorer/msvctoolchain.h @@ -64,7 +64,7 @@ public: ~MsvcToolChain() override; Abi targetAbi() const override; - QList supportedAbis() const override; + Abis supportedAbis() const override; void setTargetAbi(const Abi &abi); bool isValid() const override; @@ -168,7 +168,7 @@ private: protected: Abi m_abi; - QList m_supportedAbis; + Abis m_supportedAbis; QString m_vcvarsBat; QString m_varsBatArg; // Argument diff --git a/src/plugins/projectexplorer/toolchain.cpp b/src/plugins/projectexplorer/toolchain.cpp index 5bfceefb32f..16e67681ed4 100644 --- a/src/plugins/projectexplorer/toolchain.cpp +++ b/src/plugins/projectexplorer/toolchain.cpp @@ -179,7 +179,7 @@ Core::Id ToolChain::typeId() const return d->m_typeId; } -QList ToolChain::supportedAbis() const +Abis ToolChain::supportedAbis() const { return {targetAbi()}; } diff --git a/src/plugins/projectexplorer/toolchain.h b/src/plugins/projectexplorer/toolchain.h index 59fac8112ff..13bab867b89 100644 --- a/src/plugins/projectexplorer/toolchain.h +++ b/src/plugins/projectexplorer/toolchain.h @@ -28,6 +28,7 @@ #include "projectexplorer_export.h" #include "projectexplorer_global.h" +#include "abi.h" #include "headerpath.h" #include "projectmacro.h" #include "toolchaincache.h" @@ -104,7 +105,7 @@ public: Core::Id typeId() const; virtual QString typeDisplayName() const = 0; virtual Abi targetAbi() const = 0; - virtual QList supportedAbis() const; + virtual ProjectExplorer::Abis supportedAbis() const; virtual QString originalTargetTriple() const { return QString(); } virtual QStringList extraCodeModelFlags() const { return QStringList(); } diff --git a/src/plugins/qmakeprojectmanager/qmakeprojectimporter.cpp b/src/plugins/qmakeprojectmanager/qmakeprojectimporter.cpp index ab1b683e281..52dce303223 100644 --- a/src/plugins/qmakeprojectmanager/qmakeprojectimporter.cpp +++ b/src/plugins/qmakeprojectmanager/qmakeprojectimporter.cpp @@ -164,7 +164,7 @@ QList QmakeProjectImporter::examineDirectory(const FileName &importPath) } if (version->type() == QtSupport::Constants::DESKTOPQT) { - const QList abis = version->qtAbis(); + const ProjectExplorer::Abis abis = version->qtAbis(); if (!abis.isEmpty()) { ProjectExplorer::Abi abi = abis.first(); if (abi.os() == ProjectExplorer::Abi::DarwinOS) { @@ -271,7 +271,7 @@ static const QList preferredToolChains(BaseQtVersion *qtVersion, co const FileName spec = ms.isEmpty() ? qtVersion->mkspec() : ms; const QList toolchains = ToolChainManager::toolChains(); - QList qtAbis = qtVersion->qtAbis(); + const Abis qtAbis = qtVersion->qtAbis(); const auto matcher = [&](const ToolChain *tc) { return qtAbis.contains(tc->targetAbi()) && tc->suggestedMkspecList().contains(spec) diff --git a/src/plugins/qnx/qnxqtversion.cpp b/src/plugins/qnx/qnxqtversion.cpp index 330a1540159..354c8f0b386 100644 --- a/src/plugins/qnx/qnxqtversion.cpp +++ b/src/plugins/qnx/qnxqtversion.cpp @@ -118,7 +118,7 @@ void QnxQtVersion::fromMap(const QVariantMap &map) setSdpPath(QDir::fromNativeSeparators(map.value(QLatin1String(SDP_PATH_KEY)).toString())); } -QList QnxQtVersion::detectQtAbis() const +ProjectExplorer::Abis QnxQtVersion::detectQtAbis() const { ensureMkSpecParsed(); return QnxUtils::convertAbis(BaseQtVersion::detectQtAbis()); diff --git a/src/plugins/qnx/qnxqtversion.h b/src/plugins/qnx/qnxqtversion.h index e72f78d8fea..87ca17d9e0e 100644 --- a/src/plugins/qnx/qnxqtversion.h +++ b/src/plugins/qnx/qnxqtversion.h @@ -54,7 +54,7 @@ public: QVariantMap toMap() const override; void fromMap(const QVariantMap &map) override; - QList detectQtAbis() const override; + ProjectExplorer::Abis detectQtAbis() const override; void addToEnvironment(const ProjectExplorer::Kit *k, Utils::Environment &env) const override; Utils::Environment qmakeRunEnvironment() const override; diff --git a/src/plugins/qnx/qnxtoolchain.cpp b/src/plugins/qnx/qnxtoolchain.cpp index d1880da40f4..4ce08da1ea1 100644 --- a/src/plugins/qnx/qnxtoolchain.cpp +++ b/src/plugins/qnx/qnxtoolchain.cpp @@ -44,9 +44,9 @@ namespace Internal { static const char CompilerSdpPath[] = "Qnx.QnxToolChain.NDKPath"; static const char CpuDirKey[] = "Qnx.QnxToolChain.CpuDir"; -static QList detectTargetAbis(const FileName &sdpPath) +static Abis detectTargetAbis(const FileName &sdpPath) { - QList result; + Abis result; FileName qnxTarget; if (!sdpPath.fileName().isEmpty()) { @@ -243,7 +243,7 @@ QnxToolChainConfigWidget::QnxToolChainConfigWidget(QnxToolChain *tc) m_sdpPath->setPath(tc->sdpPath()); m_sdpPath->setEnabled(!tc->isAutoDetected()); - QList abiList = detectTargetAbis(m_sdpPath->fileName()); + const Abis abiList = detectTargetAbis(m_sdpPath->fileName()); m_abiWidget->setAbis(abiList, tc->targetAbi()); m_abiWidget->setEnabled(!tc->isAutoDetected() && !abiList.isEmpty()); @@ -295,9 +295,9 @@ bool QnxToolChainConfigWidget::isDirtyImpl() const void QnxToolChainConfigWidget::handleSdpPathChange() { - Abi currentAbi = m_abiWidget->currentAbi(); - bool customAbi = m_abiWidget->isCustomAbi(); - QList abiList = detectTargetAbis(m_sdpPath->fileName()); + const Abi currentAbi = m_abiWidget->currentAbi(); + const bool customAbi = m_abiWidget->isCustomAbi(); + const Abis abiList = detectTargetAbis(m_sdpPath->fileName()); m_abiWidget->setEnabled(!abiList.isEmpty()); diff --git a/src/plugins/qnx/qnxutils.cpp b/src/plugins/qnx/qnxutils.cpp index 0bfb4dedd89..3be4d4de4df 100644 --- a/src/plugins/qnx/qnxutils.cpp +++ b/src/plugins/qnx/qnxutils.cpp @@ -251,7 +251,7 @@ Abi QnxUtils::convertAbi(const Abi &abi) return abi; } -QList QnxUtils::convertAbis(const QList &abis) +Abis QnxUtils::convertAbis(const Abis &abis) { return Utils::transform(abis, &QnxUtils::convertAbi); } diff --git a/src/plugins/qnx/qnxutils.h b/src/plugins/qnx/qnxutils.h index 505a1a5bff8..cc3c5e0f905 100644 --- a/src/plugins/qnx/qnxutils.h +++ b/src/plugins/qnx/qnxutils.h @@ -77,7 +77,7 @@ public: static QList qnxEnvironment(const QString &sdpPath); static QList findTargets(const Utils::FileName &basePath); static ProjectExplorer::Abi convertAbi(const ProjectExplorer::Abi &abi); - static QList convertAbis(const QList &abis); + static ProjectExplorer::Abis convertAbis(const ProjectExplorer::Abis &abis); }; } // namespace Internal diff --git a/src/plugins/qtsupport/baseqtversion.cpp b/src/plugins/qtsupport/baseqtversion.cpp index e66e5dcee46..c1a91640505 100644 --- a/src/plugins/qtsupport/baseqtversion.cpp +++ b/src/plugins/qtsupport/baseqtversion.cpp @@ -359,7 +359,7 @@ QList BaseQtVersion::validateKit(const Kit *k) BaseQtVersion *version = QtKitAspect::qtVersion(k); Q_ASSERT(version == this); - const QList qtAbis = version->qtAbis(); + const Abis qtAbis = version->qtAbis(); if (qtAbis.isEmpty()) // No need to test if Qt does not know anyway... return result; @@ -379,7 +379,7 @@ QList BaseQtVersion::validateKit(const Kit *k) bool fullMatch = false; QString qtAbiString; - foreach (const Abi &qtAbi, qtAbis) { + for (const Abi &qtAbi : qtAbis) { if (!qtAbiString.isEmpty()) qtAbiString.append(' '); qtAbiString.append(qtAbi.toString()); @@ -620,7 +620,7 @@ FileName BaseQtVersion::qmakeCommand() const return m_qmakeCommand; } -QList BaseQtVersion::qtAbis() const +Abis BaseQtVersion::qtAbis() const { if (!m_hasQtAbis) { m_qtAbis = detectQtAbis(); @@ -629,7 +629,7 @@ QList BaseQtVersion::qtAbis() const return m_qtAbis; } -QList BaseQtVersion::detectQtAbis() const +Abis BaseQtVersion::detectQtAbis() const { return qtAbisFromLibrary(qtCorePaths()); } @@ -705,7 +705,7 @@ QString BaseQtVersion::toHtml(bool verbose) const } else { str << "" << QCoreApplication::translate("BaseQtVersion", "ABI:") << ""; - const QList abis = qtAbis(); + const Abis abis = qtAbis(); if (abis.isEmpty()) { str << "" << Abi().toString() << ""; } else { @@ -1558,7 +1558,7 @@ bool BaseQtVersion::queryQMakeVariables(const FileName &binary, const Environmen // Try running qmake with all kinds of tool chains set up in the environment. // This is required to make non-static qmakes work on windows where every tool chain // tries to be incompatible with any other. - QList abiList = Abi::abisOfBinary(binary); + Abis abiList = Abi::abisOfBinary(binary); const QList tcList = ToolChainManager::toolChains([&abiList](const ToolChain *t) { return abiList.contains(t->targetAbi()); }); for (ToolChain *tc : tcList) { @@ -2004,10 +2004,10 @@ static Abi scanQtBinaryForBuildStringAndRefineAbi(const FileName &library, return results.value(library); } -QList BaseQtVersion::qtAbisFromLibrary(const FileNameList &coreLibraries) +Abis BaseQtVersion::qtAbisFromLibrary(const FileNameList &coreLibraries) { - QList res; - foreach (const FileName &library, coreLibraries) { + Abis res; + for (const FileName &library : coreLibraries) { for (Abi abi : Abi::abisOfBinary(library)) { Abi tmp = abi; if (abi.osFlavor() == Abi::UnknownFlavor) diff --git a/src/plugins/qtsupport/baseqtversion.h b/src/plugins/qtsupport/baseqtversion.h index 214b3f4c343..5de6cef5d68 100644 --- a/src/plugins/qtsupport/baseqtversion.h +++ b/src/plugins/qtsupport/baseqtversion.h @@ -137,8 +137,8 @@ public: virtual QString description() const = 0; virtual QString toHtml(bool verbose) const; - QList qtAbis() const; - virtual QList detectQtAbis() const; + ProjectExplorer::Abis qtAbis() const; + virtual ProjectExplorer::Abis detectQtAbis() const; enum PropertyVariant { PropertyVariantDev, PropertyVariantGet, PropertyVariantSrc }; QString qmakeProperty(const QByteArray &name, @@ -265,7 +265,7 @@ protected: // helper function for desktop and simulator to figure out the supported abis based on the libraries Utils::FileNameList qtCorePaths() const; - static QList qtAbisFromLibrary(const Utils::FileNameList &coreLibraries); + static ProjectExplorer::Abis qtAbisFromLibrary(const Utils::FileNameList &coreLibraries); void ensureMkSpecParsed() const; virtual void parseMkSpec(ProFileEvaluator *) const; @@ -332,7 +332,7 @@ private: mutable QString m_linguistCommand; mutable QString m_qscxmlcCommand; - mutable QList m_qtAbis; + mutable ProjectExplorer::Abis m_qtAbis; MacroExpanderWrapper m_expander; }; diff --git a/src/plugins/qtsupport/qtoptionspage.cpp b/src/plugins/qtsupport/qtoptionspage.cpp index 798a4713752..94ab9cc1235 100644 --- a/src/plugins/qtsupport/qtoptionspage.cpp +++ b/src/plugins/qtsupport/qtoptionspage.cpp @@ -341,7 +341,7 @@ void QtOptionsPageWidget::infoAnchorClicked(const QUrl &url) QDesktopServices::openUrl(url); } -static QString formatAbiHtmlList(const QList &abis) +static QString formatAbiHtmlList(const Abis &abis) { QString result = QStringLiteral("
  • "); for (int i = 0, count = abis.size(); i < count; ++i) { @@ -369,8 +369,8 @@ QtOptionsPageWidget::ValidityInfo QtOptionsPageWidget::validInformation(const Ba } // Do we have tool chain issues? - QList missingToolChains; - const QList qtAbis = version->qtAbis(); + Abis missingToolChains; + const Abis qtAbis = version->qtAbis(); for (const Abi &abi : qtAbis) { const auto abiCompatePred = [&abi] (const ToolChain *tc) diff --git a/src/plugins/remotelinux/embeddedlinuxqtversion.cpp b/src/plugins/remotelinux/embeddedlinuxqtversion.cpp index 10de3a6bf59..e315cf066a3 100644 --- a/src/plugins/remotelinux/embeddedlinuxqtversion.cpp +++ b/src/plugins/remotelinux/embeddedlinuxqtversion.cpp @@ -55,8 +55,8 @@ EmbeddedLinuxQtVersionFactory::EmbeddedLinuxQtVersionFactory() setPriority(10); setRestrictionChecker([](const SetupData &) { - EmbeddedLinuxQtVersion tempVersion; - QList abis = tempVersion.qtAbis(); + const EmbeddedLinuxQtVersion tempVersion; + const ProjectExplorer::Abis abis = tempVersion.qtAbis(); // Note: This fails for e.g. intel/meego cross builds on x86 linux machines. return abis.count() == 1