feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LocatorFilters: Use ILocatorFilter::createRegExp() consistently

Browse Source 
Use it consistently inside ILocatorFilter subclasses, instead
of FuzzyMatcher.
Drop repeated default arguments from the caller.

Change-Id: I53762f27216a30ed0281f3d0ddc5e50c7452559a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Jarek Kobus
2023-05-12 16:22:04 +02:00
parent 5cf5b1ae3f
commit 2b54ef80d1
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cppeditor/cpplocatorfilter.cpp
View File

@@ -203,7 +203,7 @@ void matchesForCurrentDocument(QPromise<void> &promise, const LocatorStorage &st
const FilePath &currentFileName) const FilePath &currentFileName)
{ {
const QString input = storage.input(); const QString input = storage.input();
const QRegularExpression regexp = FuzzyMatcher::createRegExp(input, Qt::CaseInsensitive, false); const QRegularExpression regexp = ILocatorFilter::createRegExp(input);
if (!regexp.isValid()) if (!regexp.isValid())
return; return;

7
src/plugins/languageclient/locatorfilter.cpp
View File

@@ -293,11 +293,8 @@ Core::LocatorFilterEntries currentDocumentSymbols(const QString &input,
const CurrentDocumentSymbolsData &currentSymbolsData, const CurrentDocumentSymbolsData &currentSymbolsData,
const DocSymbolModifier &docSymbolModifier) const DocSymbolModifier &docSymbolModifier)
{ {
const FuzzyMatcher::CaseSensitivity caseSensitivity const Qt::CaseSensitivity caseSensitivity = ILocatorFilter::caseSensitivity(input);
= ILocatorFilter::caseSensitivity(input) == Qt::CaseSensitive const QRegularExpression regExp = ILocatorFilter::createRegExp(input, caseSensitivity);
? FuzzyMatcher::CaseSensitivity::CaseSensitive
: FuzzyMatcher::CaseSensitivity::CaseInsensitive;
const QRegularExpression regExp = FuzzyMatcher::createRegExp(input, caseSensitivity);
if (!regExp.isValid()) if (!regExp.isValid())
return {}; return {};