diff --git a/src/libs/utils/winutils.h b/src/libs/utils/winutils.h index cd8d20f178b..868519af3cf 100644 --- a/src/libs/utils/winutils.h +++ b/src/libs/utils/winutils.h @@ -69,7 +69,6 @@ QTCREATOR_UTILS_EXPORT bool winIs64BitSystem(); // Check for a 64bit binary. QTCREATOR_UTILS_EXPORT bool winIs64BitBinary(const QString &binary); - - } // namespace Utils + #endif // WINUTILS_H diff --git a/src/plugins/debugger/cdb/cdbengine.cpp b/src/plugins/debugger/cdb/cdbengine.cpp index 587662c0c82..b9e1c8e1bba 100644 --- a/src/plugins/debugger/cdb/cdbengine.cpp +++ b/src/plugins/debugger/cdb/cdbengine.cpp @@ -31,30 +31,32 @@ **************************************************************************/ #include "cdbengine.h" -#include "debuggerstartparameters.h" -#include "disassemblerlines.h" + +#include "breakhandler.h" +#include "breakpoint.h" +#include "bytearrayinputstream.h" #include "cdboptions.h" #include "cdboptionspage.h" -#include "bytearrayinputstream.h" -#include "breakpoint.h" -#include "breakhandler.h" +#include "cdbparsehelpers.h" +#include "debuggeractions.h" +#include "debuggercore.h" +#include "debuggerinternalconstants.h" +#include "debuggerrunner.h" +#include "debuggerstartparameters.h" +#include "debuggertooltipmanager.h" +#include "disassembleragent.h" +#include "disassemblerlines.h" +#include "memoryagent.h" +#include "moduleshandler.h" +#include "registerhandler.h" #include "stackframe.h" #include "stackhandler.h" -#include "watchhandler.h" #include "threadshandler.h" -#include "moduleshandler.h" -#include "debuggeractions.h" -#include "debuggerinternalconstants.h" -#include "debuggercore.h" -#include "registerhandler.h" -#include "disassembleragent.h" -#include "memoryagent.h" -#include "debuggerrunner.h" -#include "debuggertooltipmanager.h" -#include "cdbparsehelpers.h" +#include "watchhandler.h" #include "watchutils.h" #include "gdb/gdbmi.h" #include "shared/cdbsymbolpathlisteditor.h" +#include "shared/dbgwinutils.h" #include @@ -84,11 +86,6 @@ #include #include -#ifdef Q_OS_WIN -# include -# include "dbgwinutils.h" -#endif - #include Q_DECLARE_METATYPE(Debugger::Internal::DisassemblerAgent*) diff --git a/src/plugins/debugger/cdb/cdbparsehelpers.cpp b/src/plugins/debugger/cdb/cdbparsehelpers.cpp index 32db699b7b5..fb6bcac59bd 100644 --- a/src/plugins/debugger/cdb/cdbparsehelpers.cpp +++ b/src/plugins/debugger/cdb/cdbparsehelpers.cpp @@ -37,9 +37,8 @@ #include "bytearrayinputstream.h" #include "gdb/gdbmi.h" #include "disassemblerlines.h" -#ifdef Q_OS_WIN -# include "shared/dbgwinutils.h" -#endif +#include "shared/dbgwinutils.h" + #include #include diff --git a/src/plugins/debugger/debuggerdialogs.cpp b/src/plugins/debugger/debuggerdialogs.cpp index f4c03fe84a9..dd67b4e7979 100644 --- a/src/plugins/debugger/debuggerdialogs.cpp +++ b/src/plugins/debugger/debuggerdialogs.cpp @@ -34,6 +34,7 @@ #include "debuggerconstants.h" #include "cdb/cdbengine.h" +#include "shared/dbgwinutils.h" #include "ui_attachcoredialog.h" #include "ui_attachexternaldialog.h" @@ -42,10 +43,6 @@ #include "ui_startremoteenginedialog.h" #include "ui_attachtoqmlportdialog.h" -#ifdef Q_OS_WIN -# include "shared/dbgwinutils.h" -#endif - #include #include #include diff --git a/src/plugins/debugger/gdb/codagdbadapter.cpp b/src/plugins/debugger/gdb/codagdbadapter.cpp index d66150ed661..04228891ae6 100644 --- a/src/plugins/debugger/gdb/codagdbadapter.cpp +++ b/src/plugins/debugger/gdb/codagdbadapter.cpp @@ -57,9 +57,9 @@ #include #include -#ifdef Q_OS_WIN -# include "dbgwinutils.h" -#else +#include "dbgwinutils.h" + +#ifndef Q_OS_WIN # include # include #endif diff --git a/src/plugins/debugger/gdb/gdbengine.cpp b/src/plugins/debugger/gdb/gdbengine.cpp index 0125e7cd902..5f58dfceb0f 100644 --- a/src/plugins/debugger/gdb/gdbengine.cpp +++ b/src/plugins/debugger/gdb/gdbengine.cpp @@ -67,10 +67,7 @@ #include "threadshandler.h" #include "watchhandler.h" #include "debuggersourcepathmappingwidget.h" - -#ifdef Q_OS_WIN -# include "dbgwinutils.h" -#endif +#include "dbgwinutils.h" #include "logwindow.h" #include diff --git a/src/plugins/debugger/gdb/termgdbadapter.cpp b/src/plugins/debugger/gdb/termgdbadapter.cpp index 21430f2b682..688c530f1d8 100644 --- a/src/plugins/debugger/gdb/termgdbadapter.cpp +++ b/src/plugins/debugger/gdb/termgdbadapter.cpp @@ -38,17 +38,13 @@ #include "procinterrupt.h" #include "debuggerstringutils.h" #include "debuggercore.h" +#include "dbgwinutils.h" #include #include #include -#ifdef Q_OS_WIN -# include "dbgwinutils.h" -# include "dbgwinutils.h" -#endif - namespace Debugger { namespace Internal { diff --git a/src/plugins/debugger/shared/dbgwinutils.h b/src/plugins/debugger/shared/dbgwinutils.h index 93d3aff3923..8160553f87a 100644 --- a/src/plugins/debugger/shared/dbgwinutils.h +++ b/src/plugins/debugger/shared/dbgwinutils.h @@ -35,8 +35,12 @@ #include -QT_FORWARD_DECLARE_CLASS(QString) -QT_FORWARD_DECLARE_CLASS(QTextStream) +#ifdef Q_OS_WIN + +QT_BEGIN_NAMESPACE +class QString; +class QTextStream; +QT_END_NAMESPACE namespace Debugger { namespace Internal { @@ -84,4 +88,6 @@ bool isDebuggerWinException(long code); } // namespace Internal } // namespace Debugger +#endif // defined(Q_OS_WIN) + #endif // DEBUGGER_DBG_WINUTILS_H diff --git a/src/plugins/debugger/shared/shared.pri b/src/plugins/debugger/shared/shared.pri index 4df723050e8..53fd641864d 100644 --- a/src/plugins/debugger/shared/shared.pri +++ b/src/plugins/debugger/shared/shared.pri @@ -2,7 +2,8 @@ SOURCES += $$PWD/backtrace.cpp \ $$PWD/cdbsymbolpathlisteditor.cpp HEADERS += $$PWD/backtrace.h \ - $$PWD/cdbsymbolpathlisteditor.h + $$PWD/cdbsymbolpathlisteditor.h \ + $$PWD/dbgwinutils.h INCLUDEPATH+=$$PWD @@ -10,8 +11,7 @@ win32 { SOURCES += $$PWD/peutils.cpp \ $$PWD/dbgwinutils.cpp -HEADERS += $$PWD/peutils.h \ - $$PWD/dbgwinutils.h +HEADERS += $$PWD/peutils.h win32-msvc* { # For the Privilege manipulation functions in sharedlibraryinjector.cpp.