feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlJSEditor: Rename documentRevision() to editorRevision()

Browse Source 
In line with QmlJS::Document::editorRevision() and
CPPEditor::editorRevision()

Reviewed-by: Roberto Raggi
This commit is contained in:
Kai Koehne
2010-07-13 10:45:20 +02:00
parent d34c336819
commit 2bafdb71a2
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qmljseditor/qmljseditor.cpp
View File

@@ -685,14 +685,14 @@ SemanticInfo QmlJSTextEditor::semanticInfo() const
return m_semanticInfo; return m_semanticInfo;
} }
int QmlJSTextEditor::documentRevision() const int QmlJSTextEditor::editorRevision() const
{ {
return document()->revision(); return document()->revision();
} }
bool QmlJSTextEditor::isOutdated() const bool QmlJSTextEditor::isOutdated() const
{ {
if (m_semanticInfo.revision() != documentRevision()) if (m_semanticInfo.revision() != editorRevision())
return true; return true;
return false; return false;
@@ -835,7 +835,7 @@ void QmlJSTextEditor::updateMethodBoxIndex()
if (!m_semanticInfo.document) if (!m_semanticInfo.document)
return; return;
if (m_semanticInfo.document->editorRevision() != documentRevision()) { if (m_semanticInfo.document->editorRevision() != editorRevision()) {
m_updateMethodBoxTimer->start(); m_updateMethodBoxTimer->start();
return; return;
} }

2
src/plugins/qmljseditor/qmljseditor.h
View File

@@ -213,7 +213,7 @@ public:
virtual void unCommentSelection(); virtual void unCommentSelection();
SemanticInfo semanticInfo() const; SemanticInfo semanticInfo() const;
int documentRevision() const; int editorRevision() const;
bool isOutdated() const; bool isOutdated() const;
QmlOutlineModel *outlineModel() const; QmlOutlineModel *outlineModel() const;

2
src/plugins/qmljseditor/qmljseditorplugin.cpp
View File

@@ -251,7 +251,7 @@ void QmlJSEditorPlugin::quickFixNow()
if (QmlJSTextEditor *editor = qobject_cast<QmlJSTextEditor*>(m_currentTextEditable->widget())) { if (QmlJSTextEditor *editor = qobject_cast<QmlJSTextEditor*>(m_currentTextEditable->widget())) {
if (currentEditor == editor) { if (currentEditor == editor) {
if (editor->isOutdated()) { if (editor->isOutdated()) {
// qDebug() << "TODO: outdated document" << editor->documentRevision() << editor->semanticInfo().revision(); // qDebug() << "TODO: outdated document" << editor->editorRevision() << editor->semanticInfo().revision();
// ### FIXME: m_quickFixTimer->start(QUICKFIX_INTERVAL); // ### FIXME: m_quickFixTimer->start(QUICKFIX_INTERVAL);
m_quickFixTimer->stop(); m_quickFixTimer->stop();
} else { } else {

2
src/plugins/qmljseditor/qmljshoverhandler.cpp
View File

@@ -126,7 +126,7 @@ void HoverHandler::updateHelpIdAndTooltip(TextEditor::ITextEditor *editor, int p
const SemanticInfo semanticInfo = edit->semanticInfo(); const SemanticInfo semanticInfo = edit->semanticInfo();
if (semanticInfo.revision() != edit->documentRevision()) if (semanticInfo.revision() != edit->editorRevision())
return; return;
const Snapshot snapshot = semanticInfo.snapshot; const Snapshot snapshot = semanticInfo.snapshot;