feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Incredibuild: Do not rely on metaobject classnames for build steps

Browse Source 
The preferred interface are step ids, #include'ing other modules
*constants.h header is considered ok for siblings in the core
distribution and does not create run time dependencies between plugins.

Change-Id: I0421936068b459c1aea61e23310f860d8ed1f0d4
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-08-07 13:50:03 +02:00
parent 326cf1a982
commit 2bda74b46f
6 changed files with 24 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/incredibuild/makecommandbuilder.h
View File

@@ -36,7 +36,7 @@ public:
MakeCommandBuilder(ProjectExplorer::BuildStep *buildStep) : CommandBuilder(buildStep) {}
private:
bool canMigrate(ProjectExplorer::BuildStepList *buildStepList) final;
QList<Utils::Id> migratableSteps() const final;
QString id() const final { return "MakeCommandBuilder"; }
QString displayName() const final { return tr("Make"); }
QString defaultCommand() const final;