Debugger: Fresh icons for QtQuick "App on Top" and "Select"

Since these two features are revived for Qt 5.7, they deserve fresh
icons. And since they could also gain back their place in the
(qml)debugger toolbar, this patch provides also the toolbar icon
variants.

Change-Id: Id8c51aaa7ab81f594103fe1538fe6efe153af56a
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>

src/plugins/debugger/debugger.qrc

@@ -41,7 +41,9 @@
         <file>images/mode_debug_mask@2x.png</file>
         <file>images/pin.xpm</file>
         <file>images/qml/select.png</file>
+        <file>images/qml/select@2x.png</file>
         <file>images/qml/app-on-top.png</file>
+        <file>images/qml/app-on-top@2x.png</file>
         <file>images/debugger_restart_small.png</file>
         <file>images/debugger_restart_small@2x.png</file>
         <file>images/recordfill.png</file>

src/plugins/debugger/debuggericons.h

@@ -81,10 +81,14 @@ const Utils::Icon LOCATION({
 const Utils::Icon REVERSE_MODE({
         {QLatin1String(":/debugger/images/debugger_reversemode_background.png"), Utils::Theme::IconsCodeModelOverlayForegroundColor},
         {QLatin1String(":/debugger/images/debugger_reversemode.png"), Utils::Theme::IconsInfoColor}}, Utils::Icon::Tint);
-const Utils::Icon APP_ON_TOP(
-        QLatin1String(":/debugger/images/qml/app-on-top.png"));
-const Utils::Icon SELECT(
-        QLatin1String(":/debugger/images/qml/select.png"));
+const Utils::Icon APP_ON_TOP({
+        {QLatin1String(":/debugger/images/qml/app-on-top.png"), Utils::Theme::PanelTextColorMid}}, Utils::Icon::MenuTintedStyle);
+const Utils::Icon APP_ON_TOP_TOOLBAR({
+        {QLatin1String(":/debugger/images/qml/app-on-top.png"), Utils::Theme::IconsBaseColor}});
+const Utils::Icon SELECT({
+        {QLatin1String(":/debugger/images/qml/select.png"), Utils::Theme::PanelTextColorMid}}, Utils::Icon::MenuTintedStyle);
+const Utils::Icon SELECT_TOOLBAR({
+        {QLatin1String(":/debugger/images/qml/select.png"), Utils::Theme::IconsBaseColor}});
 const Utils::Icon EMPTY(
         QLatin1String(":/debugger/images/debugger_empty_14.png"));
 const Utils::Icon RECORD_ON({

src/plugins/debugger/debuggerplugin.cpp

@@ -1830,9 +1830,9 @@ bool DebuggerPluginPrivate::initialize(const QStringList &arguments,
 
 //    ToolbarDescription qmlToolbar
 //    qmlToolbar.addAction(qmlUpdateOnSaveDummyAction);
-//    qmlToolbar.addAction(qmlShowAppOnTopDummyAction);
+//    qmlToolbar.addAction(qmlShowAppOnTopDummyAction, Icons::APP_ON_TOP_TOOLBAR.icon());
 //    qmlToolbar.addWidget(new StyledSeparator);
-//    qmlToolbar.addAction(qmlSelectDummyAction);
+//    qmlToolbar.addAction(qmlSelectDummyAction, Icons::SELECT_TOOLBAR.icon());
 //    qmlToolbar.addWidget(new StyledSeparator);
 
     Perspective basePerspective({}, {

src/tools/icons/qtcreatoricons.svg

@@ -617,6 +617,17 @@
        x2="558.5"
        y2="596.5"
        gradientUnits="userSpaceOnUse" />
+    <clipPath
+       clipPathUnits="userSpaceOnUse"
+       id="clipPath6003">
+      <rect
+         style="display:inline;fill:#ffffff;fill-opacity:1"
+         x="1016"
+         y="568"
+         width="16"
+         height="16"
+         id="rect6005" />
+    </clipPath>
   </defs>
   <sodipodi:namedview
      id="base"
@@ -3170,6 +3181,78 @@
          x="0"
          style="display:inline" />
     </g>
+    <g
+       style="display:inline"
+       id="src/plugins/debugger/images/qml/app-on-top"
+       transform="translate(16,0)">
+      <rect
+         style="display:inline;fill:#ffffff;fill-opacity:1"
+         x="1016"
+         y="568"
+         width="16"
+         height="16"
+         id="rect6782-96-0-0-4" />
+      <rect
+         style="fill:#ffffff;fill-opacity:1;stroke:#000000;stroke-opacity:1"
+         id="rect5906-6-3"
+         width="10"
+         height="9"
+         x="1017.5"
+         y="569.5" />
+      <g
+         id="g6060"
+         transform="translate(0,1)">
+        <rect
+           y="572.5"
+           x="1020.5"
+           height="9"
+           width="10"
+           id="rect5906-6"
+           style="fill:#cccccc;fill-opacity:1;stroke:#000000;stroke-opacity:1.0" />
+        <path
+           inkscape:connector-curvature="0"
+           id="path6058"
+           d="m 1020.5,573.5 10,0"
+           style="fill:none;fill-rule:evenodd;stroke:#000000;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1"
+           sodipodi:nodetypes="cc" />
+      </g>
+    </g>
+    <g
+       style="display:inline"
+       id="src/plugins/debugger/images/qml/select"
+       transform="translate(32,0)"
+       clip-path="url(#clipPath6003)">
+      <rect
+         style="display:inline;fill:#ffffff;fill-opacity:1"
+         x="1016"
+         y="568"
+         width="16"
+         height="16"
+         id="rect6782-96-0-0" />
+      <rect
+         style="fill:#cccccc;fill-opacity:1;stroke:#000000;stroke-opacity:1"
+         id="rect5906"
+         width="10"
+         height="9"
+         x="1018.5"
+         y="570.5" />
+      <g
+         id="g5932"
+         transform="translate(4,0)">
+        <path
+           sodipodi:nodetypes="ccccc"
+           inkscape:connector-curvature="0"
+           id="path5927"
+           d="m 1020.5,572.5 0,10.5 3.1285,-3.17123 3.6805,-0.45312 z"
+           style="fill:#000000;fill-opacity:1;fill-rule:evenodd;stroke:#ffffff;stroke-width:1px;stroke-linecap:butt;stroke-linejoin:miter;stroke-opacity:1" />
+        <path
+           sodipodi:nodetypes="cc"
+           inkscape:connector-curvature="0"
+           id="path5930"
+           d="m 1022.8232,578 2.4453,5.0578"
+           style="fill:none;fill-rule:evenodd;stroke:#000000;stroke-width:1.29999995;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1" />
+      </g>
+    </g>
   </g>
   <g
      inkscape:groupmode="layer"