forked from qt-creator/qt-creator
		
	RemoteLinux: Simplify RsyncDeployStep implementation
Change-Id: Ife6eb2d1f7ab2202e7ddc6c13c68f3ed09403553 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
		@@ -31,19 +31,15 @@ namespace RemoteLinux {
 | 
			
		||||
class RsyncDeployStep : public AbstractRemoteLinuxDeployStep
 | 
			
		||||
{
 | 
			
		||||
public:
 | 
			
		||||
    RsyncDeployStep(ProjectExplorer::BuildStepList *bsl, Utils::Id id);
 | 
			
		||||
    ~RsyncDeployStep() override;
 | 
			
		||||
 | 
			
		||||
    static Utils::Id stepId();
 | 
			
		||||
    static QString displayName();
 | 
			
		||||
    RsyncDeployStep(BuildStepList *bsl, Id id);
 | 
			
		||||
 | 
			
		||||
private:
 | 
			
		||||
    bool isDeploymentNecessary() const final;
 | 
			
		||||
    Utils::Tasking::Group deployRecipe() final;
 | 
			
		||||
    Utils::Tasking::TaskItem mkdirTask();
 | 
			
		||||
    Utils::Tasking::TaskItem transferTask();
 | 
			
		||||
    Tasking::Group deployRecipe() final;
 | 
			
		||||
    Tasking::TaskItem mkdirTask();
 | 
			
		||||
    Tasking::TaskItem transferTask();
 | 
			
		||||
 | 
			
		||||
    mutable ProjectExplorer::FilesToTransfer m_files;
 | 
			
		||||
    mutable FilesToTransfer m_files;
 | 
			
		||||
    bool m_ignoreMissingFiles = false;
 | 
			
		||||
    QString m_flags;
 | 
			
		||||
};
 | 
			
		||||
@@ -83,8 +79,6 @@ RsyncDeployStep::RsyncDeployStep(BuildStepList *bsl, Id id)
 | 
			
		||||
    });
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
RsyncDeployStep::~RsyncDeployStep() = default;
 | 
			
		||||
 | 
			
		||||
bool RsyncDeployStep::isDeploymentNecessary() const
 | 
			
		||||
{
 | 
			
		||||
    if (m_ignoreMissingFiles)
 | 
			
		||||
@@ -148,16 +142,6 @@ Group RsyncDeployStep::deployRecipe()
 | 
			
		||||
    return Group { mkdirTask(), transferTask() };
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
Utils::Id RsyncDeployStep::stepId()
 | 
			
		||||
{
 | 
			
		||||
    return Constants::RsyncDeployStepId;
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
QString RsyncDeployStep::displayName()
 | 
			
		||||
{
 | 
			
		||||
    return Tr::tr("Deploy files via rsync");
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// Factory
 | 
			
		||||
 | 
			
		||||
RsyncDeployStepFactory::RsyncDeployStepFactory()
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user