feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Add timer based path notification compression

Browse Source 
QFileWatcher is only reporting one path per signal which is suboptimal if
you change many files at once. This patch is introducing a timer which is
waiting some time time to see if more path changes are reported and is
collecting them in a vector.

Change-Id: I50f7c21186353b199634e7b3cd5a41f8d581a31d
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2017-01-31 11:14:54 +01:00
parent 9678c09355
commit 2c55a9c569
12 changed files with 426 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
tests/unit/unittest/changedfilepathcompressor-test.cpp Normal file
View File

@@ -0,0 +1,87 @@
/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of Qt Creator.
**
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3 as published by the Free Software
** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-3.0.html.
**
****************************************************************************/
#include "googletest.h"
#include <mockchangedfilepathcompressor.h>
namespace {
using testing::ElementsAre;
using testing::Invoke;
using testing::IsEmpty;
using testing::NiceMock;
class ChangedFilePathCompressor : public testing::Test
{
protected:
void SetUp();
protected:
NiceMock<MockChangedFilePathCompressor> mockCompressor;
ClangBackEnd::ChangedFilePathCompressor<FakeTimer> compressor;
QString filePath1{"filePath1"};
QString filePath2{"filePath2"};
};
TEST_F(ChangedFilePathCompressor, AddFilePath)
{
mockCompressor.addFilePath(filePath1);
ASSERT_THAT(mockCompressor.takeFilePaths(), ElementsAre(filePath1));
}
TEST_F(ChangedFilePathCompressor, NoFilePathsAferTakenThem)
{
mockCompressor.addFilePath(filePath1);
mockCompressor.takeFilePaths();
ASSERT_THAT(mockCompressor.takeFilePaths(), IsEmpty());
}
TEST_F(ChangedFilePathCompressor, CallRestartTimerAfterAddingPath)
{
EXPECT_CALL(mockCompressor, restartTimer());
mockCompressor.addFilePath(filePath1);
}
TEST_F(ChangedFilePathCompressor, CallTimeOutAfterAddingPath)
{
EXPECT_CALL(mockCompressor, callbackCalled(ElementsAre(filePath1, filePath2)));
compressor.addFilePath(filePath1);
compressor.addFilePath(filePath2);
}
void ChangedFilePathCompressor::SetUp()
{
compressor.setCallback([&] (Utils::SmallStringVector &&filePaths) {
mockCompressor.callbackCalled(filePaths);
});
}
}