From 2cc895911401c87945f52dcf86e6990f88bf8841 Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Wed, 15 Apr 2009 16:38:32 +0200 Subject: [PATCH] Introduce option -enable-cdb to enable CDB. Reviewed-by: hjk --- doc/qtcreator.qdoc | 5 ++++- src/plugins/debugger/Debugger.pluginspec | 3 +++ src/plugins/debugger/debuggermanager.cpp | 9 +++++---- src/plugins/debugger/debuggermanager.h | 4 ++-- src/plugins/debugger/debuggerplugin.cpp | 2 +- 5 files changed, 15 insertions(+), 8 deletions(-) diff --git a/doc/qtcreator.qdoc b/doc/qtcreator.qdoc index 198aad2ed46..c7de2e6d76d 100644 --- a/doc/qtcreator.qdoc +++ b/doc/qtcreator.qdoc @@ -1297,7 +1297,10 @@ When building \e{Qt Creator} using the \e{Microsoft Visual C++ Compiler}, the location \c{"%ProgramFiles%\Debugging Tools for Windows"} will be checked for the required include files. - \ + + \note As of version 1.2, the command line option \c{-enable-cdb} has to be passed + to Qt Creator to enable support for this engine. + \endtable */ diff --git a/src/plugins/debugger/Debugger.pluginspec b/src/plugins/debugger/Debugger.pluginspec index 497520d69aa..da8d04450ff 100644 --- a/src/plugins/debugger/Debugger.pluginspec +++ b/src/plugins/debugger/Debugger.pluginspec @@ -24,4 +24,7 @@ will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html. + + + diff --git a/src/plugins/debugger/debuggermanager.cpp b/src/plugins/debugger/debuggermanager.cpp index 5f8f07aed0e..fc5f3371f57 100644 --- a/src/plugins/debugger/debuggermanager.cpp +++ b/src/plugins/debugger/debuggermanager.cpp @@ -148,9 +148,9 @@ extern IDebuggerEngine *createWinEngine(DebuggerManager *) #endif extern IDebuggerEngine *createScriptEngine(DebuggerManager *parent); -DebuggerManager::DebuggerManager() +DebuggerManager::DebuggerManager(const QStringList &arguments) { - init(); + init(arguments); } DebuggerManager::~DebuggerManager() @@ -160,7 +160,7 @@ DebuggerManager::~DebuggerManager() delete scriptEngine; } -void DebuggerManager::init() +void DebuggerManager::init(const QStringList &arguments) { m_status = -1; m_busy = false; @@ -427,7 +427,8 @@ void DebuggerManager::init() setStatus(DebuggerProcessNotReady); gdbEngine = createGdbEngine(this); - winEngine = createWinEngine(this); + if (arguments.contains(QLatin1String("-enable-cdb"))) + winEngine = createWinEngine(this); scriptEngine = createScriptEngine(this); setDebuggerType(GdbDebugger); if (Debugger::Constants::Internal::debug) diff --git a/src/plugins/debugger/debuggermanager.h b/src/plugins/debugger/debuggermanager.h index b9709a68fa5..b6cf4b78f40 100644 --- a/src/plugins/debugger/debuggermanager.h +++ b/src/plugins/debugger/debuggermanager.h @@ -178,7 +178,7 @@ class DebuggerManager : public QObject, Q_OBJECT public: - DebuggerManager(); + DebuggerManager(const QStringList &arguments); ~DebuggerManager(); IDebuggerManagerAccessForEngines *engineInterface(); @@ -341,7 +341,7 @@ public: bool m_useTerminal; private: - void init(); + void init(const QStringList &arguments); void setDebuggerType(DebuggerType type); void runTest(const QString &fileName); QDockWidget *createDockForWidget(QWidget *widget); diff --git a/src/plugins/debugger/debuggerplugin.cpp b/src/plugins/debugger/debuggerplugin.cpp index 8a1cb6baca7..90cb7bd1f79 100644 --- a/src/plugins/debugger/debuggerplugin.cpp +++ b/src/plugins/debugger/debuggerplugin.cpp @@ -470,7 +470,7 @@ bool DebuggerPlugin::initialize(const QStringList &arguments, QString *errorMess Q_UNUSED(arguments); Q_UNUSED(errorMessage); - m_manager = new DebuggerManager; + m_manager = new DebuggerManager(arguments); ICore *core = ICore::instance(); QTC_ASSERT(core, return false);