From 2cd2324963b7f0ea23e0e6aad5cd04ad42cda049 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@qt.io>
Date: Wed, 17 May 2023 13:00:47 +0200
Subject: [PATCH] CheckableMessageBox: Simplify checkbox setup

If the dialog is shown, the checkbox must be unchecked, because
otherwise the dialog would not have been shown.

Change-Id: I34e8034975baef710997e0cdb3c7d2f8b0c94cd2
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
---
 src/libs/utils/checkablemessagebox.cpp | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/libs/utils/checkablemessagebox.cpp b/src/libs/utils/checkablemessagebox.cpp
index 29951fd9c44..bf566e53a8a 100644
--- a/src/libs/utils/checkablemessagebox.cpp
+++ b/src/libs/utils/checkablemessagebox.cpp
@@ -64,19 +64,11 @@ static QMessageBox::StandardButton exec(
             return acceptButton;
 
         msgBox.setCheckBox(new QCheckBox);
+        msgBox.checkBox()->setChecked(false);
 
         std::visit(
             [&msgBox](auto &&decider) {
-                using T = std::decay_t<decltype(decider)>;
                 msgBox.checkBox()->setText(decider.text);
-                if constexpr (std::is_same_v<T, CheckableMessageBox::BoolDecision>) {
-                    msgBox.checkBox()->setChecked(decider.doNotAskAgain);
-                } else if constexpr (std::is_same_v<T, CheckableMessageBox::SettingsDecision>) {
-                    msgBox.checkBox()->setChecked(
-                        decider.settings->value(decider.settingsSubKey, false).toBool());
-                } else if constexpr (std::is_same_v<T, CheckableMessageBox::AspectDecision>) {
-                    msgBox.checkBox()->setChecked(decider.aspect.value());
-                }
             },
             *decider);
     }