From 2cd44a546f5dd15cd286ec33744c1d876f8adcde Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 24 Feb 2020 14:58:36 +0100 Subject: [PATCH] ProjectExplorer: Inline RunConfiguration::isActive ... into the only internal caller. The use there is dubious to some degree. Change-Id: Icfa7437b3fdaa4dbd73fe9965a88abf4700cd3e0 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/runconfiguration.cpp | 9 +++------ src/plugins/projectexplorer/runconfiguration.h | 2 -- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp index 03c908a8596..303f6298a56 100644 --- a/src/plugins/projectexplorer/runconfiguration.cpp +++ b/src/plugins/projectexplorer/runconfiguration.cpp @@ -204,11 +204,6 @@ RunConfiguration::RunConfiguration(Target *target, Core::Id id) RunConfiguration::~RunConfiguration() = default; -bool RunConfiguration::isActive() const -{ - return target()->isActive() && target()->activeRunConfiguration() == this; -} - QString RunConfiguration::disabledReason() const { BuildSystem *bs = activeBuildSystem(); @@ -305,7 +300,9 @@ void RunConfiguration::update() emit enabledChanged(); - if (isActive() && project() == SessionManager::startupProject()) + const bool isActive = target()->isActive() && target()->activeRunConfiguration() == this; + + if (isActive && project() == SessionManager::startupProject()) emit ProjectExplorerPlugin::instance()->updateRunActions(); } diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h index 053bd600136..995cc783723 100644 --- a/src/plugins/projectexplorer/runconfiguration.h +++ b/src/plugins/projectexplorer/runconfiguration.h @@ -127,8 +127,6 @@ class PROJECTEXPLORER_EXPORT RunConfiguration : public ProjectConfiguration public: ~RunConfiguration() override; - bool isActive() const; - virtual QString disabledReason() const; virtual bool isEnabled() const;