From 2ce647f885dc371df2b6a1c904983fd6dab28b07 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Mon, 5 Dec 2016 14:30:03 +0100 Subject: [PATCH] ProjectExplorer: Fix potential nullptr access Change-Id: If5e4a9b3ba3eb25549406be76c5f14e2479b7cf4 Reviewed-by: Tim Jenssen --- src/plugins/qmakeprojectmanager/qmakenodes.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmakeprojectmanager/qmakenodes.cpp b/src/plugins/qmakeprojectmanager/qmakenodes.cpp index 0881b6313a6..cbe8a7445fa 100644 --- a/src/plugins/qmakeprojectmanager/qmakenodes.cpp +++ b/src/plugins/qmakeprojectmanager/qmakenodes.cpp @@ -1304,12 +1304,13 @@ bool QmakePriFileNode::setProVariable(const QString &var, const QStringList &val ProFile *includeFile = pair.first; QStringList lines = pair.second; + if (!includeFile) + return false; + ProWriter::putVarValues(includeFile, &lines, values, var, ProWriter::PutFlags(flags), scope); - if (!includeFile) - return false; save(lines); includeFile->deref(); return true;