feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Remove some needless indirection in BaseTextEditor

Browse Source 
Change-Id: Ibb446fce6365a0c52ad74d366f24a202ea9cc33f
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
This commit is contained in:
hjk
2014-08-20 22:01:53 +02:00
parent 3ac0668d5c
commit 2cf2dadffb
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/texteditor/basetexteditor.cpp
View File

@@ -170,12 +170,10 @@ public:
signals:
void updateRequest(int position, QPointF lastPos, QRectF rect);
private slots:
private:
void step(qreal v);
private:
QTimeLine *m_timeline;
QTimeLine m_timeline;
qreal m_value;
int m_position;
QPointF m_lastDrawPos;
@@ -5447,17 +5445,15 @@ void BaseTextEditorWidgetPrivate::_q_animateUpdate(int position, QPointF lastPos
BaseTextEditorAnimator::BaseTextEditorAnimator(QObject *parent)
:QObject(parent)
: QObject(parent), m_timeline(256)
{
m_value = 0;
m_timeline = new QTimeLine(256, this);
m_timeline->setCurveShape(QTimeLine::SineCurve);
connect(m_timeline, SIGNAL(valueChanged(qreal)), this, SLOT(step(qreal)));
connect(m_timeline, SIGNAL(finished()), this, SLOT(deleteLater()));
m_timeline->start();
m_timeline.setCurveShape(QTimeLine::SineCurve);
connect(&m_timeline, &QTimeLine::valueChanged, this, &BaseTextEditorAnimator::step);
connect(&m_timeline, &QTimeLine::finished, this, &QObject::deleteLater);
m_timeline.start();
}
void BaseTextEditorAnimator::setData(const QFont &f, const QPalette &pal, const QString &text)
{
m_font = f;
@@ -5484,7 +5480,7 @@ void BaseTextEditorAnimator::draw(QPainter *p, const QPointF &pos)
bool BaseTextEditorAnimator::isRunning() const
{
return m_timeline->state() == QTimeLine::Running;
return m_timeline.state() == QTimeLine::Running;
}
QRectF BaseTextEditorAnimator::rect() const
@@ -5506,7 +5502,7 @@ void BaseTextEditorAnimator::step(qreal v)
void BaseTextEditorAnimator::finish()
{
m_timeline->stop();
m_timeline.stop();
step(0);
deleteLater();
}