feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Prefer ITestBase::type() to ITestBase::asTest*()

Browse Source 
The casting provided by the asTest*() methods isn't made use of here, so
using the "data-oriented" type() method seems more expressive.

Change-Id: Ia3e1a28d126f096afed54eeb0d884c52332f4350
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Bernhard Beschow
2021-01-25 16:19:38 +01:00
parent e740295b8d
commit 2d92ae391a
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/autotest/testtreemodel.cpp
View File

@@ -374,7 +374,7 @@ void TestTreeModel::synchronizeTestTools()
QList<ITestTreeItem *> oldFrameworkRoots;
for (Utils::TreeItem *oldFrameworkRoot : *invisibleRoot) {
auto item = static_cast<ITestTreeItem *>(oldFrameworkRoot);
if (item->testBase()->asTestTool())
if (item->testBase()->type() == ITestBase::Tool)
oldFrameworkRoots.append(item);
}