feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use fewer QVariantMaps to create memory event details

Browse Source 
Change-Id: Ief0b14ae2be15bf5e9db31d8f6625882a17f685a
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2014-07-11 10:09:08 +02:00
parent 4d820f05f6
commit 2d93a34d18
1 changed files with 16 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
plugins/qmlprofilerextension/memoryusagemodel.cpp
View File

@@ -139,45 +139,30 @@ const QVariantList MemoryUsageModel::getLabels() const
const QVariantList MemoryUsageModel::getEventDetails(int index) const const QVariantList MemoryUsageModel::getEventDetails(int index) const
{ {
Q_D(const MemoryUsageModel); Q_D(const MemoryUsageModel);
static QString title = QStringLiteral("title");
QVariantList result; QVariantList result;
const MemoryUsageModelPrivate::Range *ev = &d->range(index); const MemoryUsageModelPrivate::Range *ev = &d->range(index);
{ QVariantMap res;
QVariantMap res; if (ev->delta > 0)
if (ev->delta > 0) res.insert(title, tr("Memory Allocated"));
res.insert(QLatin1String("title"), QVariant(QLatin1String("Memory Allocated"))); else
else res.insert(title, tr("Memory Freed"));
res.insert(QLatin1String("title"), QVariant(QLatin1String("Memory Freed"))); result << res;
res.clear();
result << res; res.insert(tr("Total"), QVariant(QString::fromLatin1("%1 bytes").arg(ev->size)));
} result << res;
res.clear();
{
QVariantMap res;
res.insert(tr("Total"), QVariant(QString::fromLatin1("%1 bytes").arg(ev->size)));
result << res;
}
{
QVariantMap res;
res.insert(tr("Allocation"), QVariant(QString::fromLatin1("%1 bytes").arg(ev->delta)));
result << res;
}
{
QVariantMap res;
res.insert(tr("Type"), QVariant(MemoryUsageModelPrivate::memoryTypeName(ev->type)));
result << res;
}
res.insert(tr("Allocation"), QVariant(QString::fromLatin1("%1 bytes").arg(ev->delta)));
res.insert(tr("Type"), QVariant(MemoryUsageModelPrivate::memoryTypeName(ev->type)));
if (ev->originTypeIndex != -1) { if (ev->originTypeIndex != -1) {
QVariantMap valuePair; res.insert(tr("Location"),
valuePair.insert(tr("Location"),
d->modelManager->qmlModel()->getEventTypes().at(ev->originTypeIndex).displayName); d->modelManager->qmlModel()->getEventTypes().at(ev->originTypeIndex).displayName);
result << valuePair;
} }
result << res;
return result; return result;
} }