feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Remove "Clear selection" button in Settings

Browse Source 
The "Clear selection" button doesn't add much value in the list
of buttons.

If you have a selection it doesn't really matter, and you can
simply click on an item an the new item will be the new
selection.

Change-Id: Ie64bc379773219392c12da4c256afd462d4081a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Cristian Adam
2021-12-22 19:58:11 +01:00
parent 35cde5ddae
commit 2d9dde30dc
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -141,7 +141,6 @@ private:
QPushButton *m_setButton; QPushButton *m_setButton;
QPushButton *m_unsetButton; QPushButton *m_unsetButton;
QPushButton *m_resetButton; QPushButton *m_resetButton;
QPushButton *m_clearSelectionButton;
QCheckBox *m_showAdvancedCheckBox; QCheckBox *m_showAdvancedCheckBox;
QPushButton *m_reconfigureButton; QPushButton *m_reconfigureButton;
QTimer m_showProgressTimer; QTimer m_showProgressTimer;
@@ -309,10 +308,6 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
m_resetButton->setToolTip(tr("Reset all unapplied changes.")); m_resetButton->setToolTip(tr("Reset all unapplied changes."));
m_resetButton->setEnabled(false); m_resetButton->setEnabled(false);
m_clearSelectionButton = new QPushButton(tr("Clear Selection"));
m_clearSelectionButton->setToolTip(tr("Clear selection."));
m_clearSelectionButton->setEnabled(false);
m_batchEditButton = new QPushButton(tr("Batch Edit...")); m_batchEditButton = new QPushButton(tr("Batch Edit..."));
m_batchEditButton->setToolTip(tr("Set or reset multiple values in the CMake Configuration.")); m_batchEditButton->setToolTip(tr("Set or reset multiple values in the CMake Configuration."));
@@ -335,7 +330,6 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
m_editButton, m_editButton,
m_setButton, m_setButton,
m_unsetButton, m_unsetButton,
m_clearSelectionButton,
m_resetButton, m_resetButton,
m_batchEditButton, m_batchEditButton,
Space(10), Space(10),
@@ -434,9 +428,6 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
m_configView->setCurrentIndex(idx); m_configView->setCurrentIndex(idx);
m_configView->edit(idx); m_configView->edit(idx);
}); });
connect(m_clearSelectionButton, &QPushButton::clicked, this, [this]() {
m_configView->selectionModel()->clear();
});
connect(addButtonMenu, &QMenu::triggered, this, [this](QAction *action) { connect(addButtonMenu, &QMenu::triggered, this, [this](QAction *action) {
ConfigModel::DataItem::Type type = ConfigModel::DataItem::Type type =
static_cast<ConfigModel::DataItem::Type>(action->data().value<int>()); static_cast<ConfigModel::DataItem::Type>(action->data().value<int>());
@@ -686,7 +677,6 @@ void CMakeBuildSettingsWidget::updateSelection()
editableCount++; editableCount++;
} }
m_clearSelectionButton->setEnabled(!selectedIndexes.isEmpty());
m_setButton->setEnabled(setableCount > 0); m_setButton->setEnabled(setableCount > 0);
m_unsetButton->setEnabled(unsetableCount > 0); m_unsetButton->setEnabled(unsetableCount > 0);
m_editButton->setEnabled(editableCount == 1); m_editButton->setEnabled(editableCount == 1);