From 2ddfd1f273a5951257017c4a194d1768f91f193d Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 2 Jan 2025 16:28:53 +0100 Subject: [PATCH] ProfProfiler: Simplify setting dependency Change-Id: I75feca18c52454515c1004e3f82d10fb1aa87d9a Reviewed-by: hjk --- src/plugins/perfprofiler/perfprofilerruncontrol.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/plugins/perfprofiler/perfprofilerruncontrol.cpp b/src/plugins/perfprofiler/perfprofilerruncontrol.cpp index e0f200eae8b..de54818cf0b 100644 --- a/src/plugins/perfprofiler/perfprofilerruncontrol.cpp +++ b/src/plugins/perfprofiler/perfprofilerruncontrol.cpp @@ -96,10 +96,9 @@ public: // If the parser is gone, there is no point in going on. m_perfParserWorker->setEssential(true); + m_perfRecordWorker = qobject_cast(runControl->createWorker("PerfRecorder")); - if ((m_perfRecordWorker = qobject_cast(runControl->createWorker("PerfRecorder")))) { - m_perfParserWorker->addStartDependency(m_perfRecordWorker); - } else { + if (!m_perfRecordWorker) { m_perfRecordWorker = new ProcessRunner(runControl); m_perfRecordWorker->suppressDefaultStdOutHandling(); @@ -118,14 +117,13 @@ public: appendMessage("Starting Perf: " + cmd.toUserOutput(), NormalMessageFormat); }); - m_perfRecordWorker->addStartDependency(m_perfParserWorker); - // In the local case, the parser won't automatically stop when the recorder does. So we need // to mark the recorder as essential, too. m_perfRecordWorker->setEssential(true); } addStartDependency(m_perfRecordWorker); + m_perfParserWorker->addStartDependency(m_perfRecordWorker); m_perfParserWorker->addStopDependency(m_perfRecordWorker); PerfProfilerTool::instance()->onWorkerCreation(runControl); }