feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Macros: Avoid repetitive calls

Browse Source 
Change-Id: If0c0694fe4bc01066b31b430d087de1b64ed8e0a
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Orgad Shaneh
2014-05-19 18:34:12 +03:00
committed by Orgad Shaneh
parent 3251d0dcb6
commit 2df6d1c428
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/macros/macrooptionswidget.cpp
View File

@@ -102,16 +102,17 @@ void MacroOptionsWidget::createTable()
QMapIterator<QString, Macro *> it(MacroManager::macros());
while (it.hasNext()) {
it.next();
QFileInfo fileInfo(it.value()->fileName());
Macro *macro = it.value();
QFileInfo fileInfo(macro->fileName());
if (fileInfo.absoluteDir() == dir.absolutePath()) {
QTreeWidgetItem *macroItem = new QTreeWidgetItem(m_ui->treeWidget);
macroItem->setText(0, it.value()->displayName());
macroItem->setText(1, it.value()->description());
macroItem->setData(0, NAME_ROLE, it.value()->displayName());
macroItem->setData(0, WRITE_ROLE, it.value()->isWritable());
macroItem->setText(0, macro->displayName());
macroItem->setText(1, macro->description());
macroItem->setData(0, NAME_ROLE, macro->displayName());
macroItem->setData(0, WRITE_ROLE, macro->isWritable());
Core::Command *command =
Core::ActionManager::command(base.withSuffix(it.value()->displayName()));
Core::ActionManager::command(base.withSuffix(macro->displayName()));
if (command && command->action())
macroItem->setText(2, command->action()->shortcut().toString());
}