From 2df6d1c4288b9cbb02b363a27d9b3f72b58db9ba Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Mon, 19 May 2014 18:34:12 +0300 Subject: [PATCH] Macros: Avoid repetitive calls Change-Id: If0c0694fe4bc01066b31b430d087de1b64ed8e0a Reviewed-by: Eike Ziller --- src/plugins/macros/macrooptionswidget.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/plugins/macros/macrooptionswidget.cpp b/src/plugins/macros/macrooptionswidget.cpp index 3880002c6f5..d3b77cce765 100644 --- a/src/plugins/macros/macrooptionswidget.cpp +++ b/src/plugins/macros/macrooptionswidget.cpp @@ -102,16 +102,17 @@ void MacroOptionsWidget::createTable() QMapIterator it(MacroManager::macros()); while (it.hasNext()) { it.next(); - QFileInfo fileInfo(it.value()->fileName()); + Macro *macro = it.value(); + QFileInfo fileInfo(macro->fileName()); if (fileInfo.absoluteDir() == dir.absolutePath()) { QTreeWidgetItem *macroItem = new QTreeWidgetItem(m_ui->treeWidget); - macroItem->setText(0, it.value()->displayName()); - macroItem->setText(1, it.value()->description()); - macroItem->setData(0, NAME_ROLE, it.value()->displayName()); - macroItem->setData(0, WRITE_ROLE, it.value()->isWritable()); + macroItem->setText(0, macro->displayName()); + macroItem->setText(1, macro->description()); + macroItem->setData(0, NAME_ROLE, macro->displayName()); + macroItem->setData(0, WRITE_ROLE, macro->isWritable()); Core::Command *command = - Core::ActionManager::command(base.withSuffix(it.value()->displayName())); + Core::ActionManager::command(base.withSuffix(macro->displayName())); if (command && command->action()) macroItem->setText(2, command->action()->shortcut().toString()); }