From 2e556c96b6c867232ee844495f38d1ee267e43fd Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 24 Jul 2019 16:23:50 +0300 Subject: [PATCH] QmlProfiler: avoid using Q_FOREACH over QVarLengthArray The squeeze() function is called by clients for QVLA's, which means it's copying 1-2KiB of data (depending on sizeof(value_type)) just to iterate over a small part of it. Use a C++11 ranged for loop. Change-Id: I2c33ae0c5a3d9d941cd9e385fc6bbb4fb0fa3c2c Reviewed-by: hjk --- src/plugins/qmlprofiler/qmlevent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmlprofiler/qmlevent.h b/src/plugins/qmlprofiler/qmlevent.h index dc1b85116dd..344ef1a7cef 100644 --- a/src/plugins/qmlprofiler/qmlevent.h +++ b/src/plugins/qmlprofiler/qmlevent.h @@ -251,7 +251,7 @@ private: squeeze(const Container &numbers) { using Small = typename QIntegerForSize::Signed; - foreach (Number item, numbers) { + for (Number item : numbers) { if (!squeezable(item)) return false; }