From 2e8ec2f9e61a855cec878a00ca0156d1ec49c484 Mon Sep 17 00:00:00 2001
From: Christian Kamm <christian.d.kamm@nokia.com>
Date: Tue, 31 Aug 2010 10:23:48 +0200
Subject: [PATCH] QmlJS: Fix performance problem in Snapshot.

Don't use QMultiHash::values(key), it rebuilds the values list from
scratch for each lookup.

Reviewed-by: Roberto Raggi
---
 src/libs/qmljs/qmljsdocument.cpp | 11 ++++++++---
 src/libs/qmljs/qmljsdocument.h   |  2 +-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/libs/qmljs/qmljsdocument.cpp b/src/libs/qmljs/qmljsdocument.cpp
index cbd61313a94..8cad21c1d41 100644
--- a/src/libs/qmljs/qmljsdocument.cpp
+++ b/src/libs/qmljs/qmljsdocument.cpp
@@ -339,7 +339,7 @@ void Snapshot::insert(const Document::Ptr &document)
         const QString path = document->path();
 
         remove(fileName);
-        _documentsByPath.insert(path, document);
+        _documentsByPath[path].append(document);
         _documents.insert(fileName, document);
     }
 }
@@ -353,7 +353,12 @@ void Snapshot::remove(const QString &fileName)
 {
     Document::Ptr doc = _documents.value(fileName);
     if (!doc.isNull()) {
-        _documentsByPath.remove(doc->path(), doc);
+        const QString &path = doc->path();
+
+        QList<Document::Ptr> docs = _documentsByPath.value(path);
+        docs.removeAll(doc);
+        _documentsByPath[path] = docs;
+
         _documents.remove(fileName);
     }
 }
@@ -378,7 +383,7 @@ Document::Ptr Snapshot::document(const QString &fileName) const
 
 QList<Document::Ptr> Snapshot::documentsInDirectory(const QString &path) const
 {
-    return _documentsByPath.values(QDir::cleanPath(path));
+    return _documentsByPath.value(QDir::cleanPath(path));
 }
 
 LibraryInfo Snapshot::libraryInfo(const QString &path) const
diff --git a/src/libs/qmljs/qmljsdocument.h b/src/libs/qmljs/qmljsdocument.h
index fd5c0fbb55f..8e3a3418013 100644
--- a/src/libs/qmljs/qmljsdocument.h
+++ b/src/libs/qmljs/qmljsdocument.h
@@ -146,7 +146,7 @@ class QMLJS_EXPORT Snapshot
 {
     typedef QHash<QString, Document::Ptr> _Base;
     QHash<QString, Document::Ptr> _documents;
-    QMultiHash<QString, Document::Ptr> _documentsByPath;
+    QHash<QString, QList<Document::Ptr> > _documentsByPath;
     QHash<QString, LibraryInfo> _libraries;
 
 public: