feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Improve code readability in EnvironmentKitAspect

Browse Source 
Change-Id: I6f19f8616b940457893ed065ae81646ae64f57a8
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2024-11-18 17:34:36 +01:00
parent 2b5dc3d606
commit 2ea5361e0a
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/projectexplorer/kitaspects.cpp
View File

@@ -263,14 +263,15 @@ private:
m_vslangCheckbox->setToolTip(Tr::tr("Either switches MSVC to English or keeps the language and " m_vslangCheckbox->setToolTip(Tr::tr("Either switches MSVC to English or keeps the language and "
"just forces UTF-8 output (may vary depending on the used MSVC " "just forces UTF-8 output (may vary depending on the used MSVC "
"compiler).")); "compiler)."));
if (enforcesMSVCEnglish(EnvironmentKitAspect::environmentChanges(kit()))) m_vslangCheckbox->setChecked(
m_vslangCheckbox->setChecked(true); enforcesMSVCEnglish(EnvironmentKitAspect::environmentChanges(kit())));
connect(m_vslangCheckbox, &QCheckBox::clicked, this, [this](bool checked) { connect(m_vslangCheckbox, &QCheckBox::clicked, this, [this](bool checked) {
EnvironmentItems changes = EnvironmentKitAspect::environmentChanges(kit()); EnvironmentItems changes = EnvironmentKitAspect::environmentChanges(kit());
if (!checked && changes.indexOf(forceMSVCEnglishItem()) >= 0) const bool hasVsLangEntry = enforcesMSVCEnglish(changes);
changes.removeAll(forceMSVCEnglishItem()); if (checked && !hasVsLangEntry)
if (checked && changes.indexOf(forceMSVCEnglishItem()) < 0)
changes.append(forceMSVCEnglishItem()); changes.append(forceMSVCEnglishItem());
else if (!checked && hasVsLangEntry)
changes.removeAll(forceMSVCEnglishItem());
EnvironmentKitAspect::setEnvironmentChanges(kit(), changes); EnvironmentKitAspect::setEnvironmentChanges(kit(), changes);
}); });
} }