From 2eb97663c72e55195b3b3d7a58777af16069d522 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Thu, 19 Sep 2024 17:50:30 +0200 Subject: [PATCH] ExtensionManager: Guard usage of __DATE__ Use __DATE__ only if no reproducible build is required. Don't show a date in the ExtensionManager if there is none. Amends: 07000281daf7777293d5236361b7e9a322482ad7 Change-Id: I419ce742c6c7358d7a294ea4d239aca07ef7890e Reviewed-by: Eike Ziller --- src/plugins/extensionmanager/extensionmanagerwidget.cpp | 6 +++++- src/plugins/extensionmanager/extensionsmodel.cpp | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/plugins/extensionmanager/extensionmanagerwidget.cpp b/src/plugins/extensionmanager/extensionmanagerwidget.cpp index dcf065fcd27..34c96de5f0b 100644 --- a/src/plugins/extensionmanager/extensionmanagerwidget.cpp +++ b/src/plugins/extensionmanager/extensionmanagerwidget.cpp @@ -609,7 +609,11 @@ void ExtensionManagerWidget::updateView(const QModelIndex ¤t) }; const QDate dateUpdated = current.data(RoleDateUpdated).toDate(); - m_dateUpdated->setText(dateUpdated.toString()); + const bool hasDateUpdated = dateUpdated.isValid(); + if (hasDateUpdated) + m_dateUpdated->setText(dateUpdated.toString()); + m_dateUpdatedTitle->setVisible(hasDateUpdated); + m_dateUpdated->setVisible(hasDateUpdated); const QStringList tags = current.data(RoleTags).toStringList(); m_tags->setTags(tags); diff --git a/src/plugins/extensionmanager/extensionsmodel.cpp b/src/plugins/extensionmanager/extensionsmodel.cpp index 2c4100f2239..b3d63073f90 100644 --- a/src/plugins/extensionmanager/extensionsmodel.cpp +++ b/src/plugins/extensionmanager/extensionsmodel.cpp @@ -209,8 +209,10 @@ QVariant ExtensionsModelPrivate::dataFromLocalPlugin(int index, int role) const : QStringList(platformsPattern); return platforms; } +#ifdef QTC_SHOW_BUILD_DATE case RoleDateUpdated: return QDate::fromString(QLatin1String(__DATE__), "MMM dd yyyy"); +#endif case RoleVendor: return pluginSpec->vendor(); case RoleVendorId: