Debugger: Use override consistently

clang-tidy fixes from modernize-use-override check.

Change-Id: I6a20484716dc5bd84fe9592b40ae57be66fe32bf
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-07 15:06:53 +02:00
parent 3890f5d67d
commit 2ec6cf1041
18 changed files with 45 additions and 45 deletions

View File

@@ -46,7 +46,7 @@ class DEBUGGER_EXPORT AnalyzerRunConfigWidget : public ProjectExplorer::RunConfi
public: public:
AnalyzerRunConfigWidget(ProjectExplorer::IRunConfigurationAspect *aspect); AnalyzerRunConfigWidget(ProjectExplorer::IRunConfigurationAspect *aspect);
QString displayName() const; QString displayName() const override;
private: private:
void chooseSettings(int setting); void chooseSettings(int setting);

View File

@@ -38,7 +38,7 @@ class DEBUGGER_EXPORT DetailedErrorView : public QTreeView
public: public:
DetailedErrorView(QWidget *parent = nullptr); DetailedErrorView(QWidget *parent = nullptr);
~DetailedErrorView(); ~DetailedErrorView() override;
void goNext(); void goNext();
void goBack(); void goBack();

View File

@@ -54,23 +54,23 @@ class Console : public Core::IOutputPane
public: public:
Console(); Console();
~Console(); ~Console() override;
QWidget *outputWidget(QWidget *); QWidget *outputWidget(QWidget *) override;
QList<QWidget *> toolBarWidgets() const; QList<QWidget *> toolBarWidgets() const override;
QString displayName() const { return tr("Debugger Console"); } QString displayName() const override { return tr("Debugger Console"); }
int priorityInStatusBar() const; int priorityInStatusBar() const override;
void clearContents(); void clearContents() override;
void visibilityChanged(bool visible); void visibilityChanged(bool visible) override;
bool canFocus() const; bool canFocus() const override;
bool hasFocus() const; bool hasFocus() const override;
void setFocus(); void setFocus() override;
bool canNext() const; bool canNext() const override;
bool canPrevious() const; bool canPrevious() const override;
void goToNext(); void goToNext() override;
void goToPrev(); void goToPrev() override;
bool canNavigate() const; bool canNavigate() const override;
void readSettings(); void readSettings();
void setContext(const QString &context); void setContext(const QString &context);

View File

@@ -56,7 +56,7 @@ class DebuggerSettings : public QObject
public: public:
explicit DebuggerSettings(); explicit DebuggerSettings();
~DebuggerSettings(); ~DebuggerSettings() override;
void insertItem(int code, Utils::SavedAction *item); void insertItem(int code, Utils::SavedAction *item);
Utils::SavedAction *item(int code) const; Utils::SavedAction *item(int code) const;

View File

@@ -70,7 +70,7 @@ class StartApplicationDialog : public QDialog
public: public:
explicit StartApplicationDialog(QWidget *parent); explicit StartApplicationDialog(QWidget *parent);
~StartApplicationDialog(); ~StartApplicationDialog() override;
static void attachToRemoteServer(); static void attachToRemoteServer();
static void startAndDebugApplication(); static void startAndDebugApplication();
@@ -93,7 +93,7 @@ class AttachToQmlPortDialog : public QDialog
public: public:
explicit AttachToQmlPortDialog(QWidget *parent); explicit AttachToQmlPortDialog(QWidget *parent);
~AttachToQmlPortDialog(); ~AttachToQmlPortDialog() override;
int port() const; int port() const;
void setPort(const int port); void setPort(const int port);
@@ -111,14 +111,14 @@ class StartRemoteCdbDialog : public QDialog
public: public:
explicit StartRemoteCdbDialog(QWidget *parent); explicit StartRemoteCdbDialog(QWidget *parent);
~StartRemoteCdbDialog(); ~StartRemoteCdbDialog() override;
QString connection() const; QString connection() const;
void setConnection(const QString &); void setConnection(const QString &);
private: private:
void textChanged(const QString &); void textChanged(const QString &);
void accept(); void accept() override;
QPushButton *m_okButton; QPushButton *m_okButton;
QLineEdit *m_lineEdit; QLineEdit *m_lineEdit;
@@ -136,7 +136,7 @@ public:
private: private:
void textChanged(); void textChanged();
void accept(); void accept() override;
void setOkButtonEnabled(bool v); void setOkButtonEnabled(bool v);
bool isOkButtonEnabled() const; bool isOkButtonEnabled() const;
@@ -153,7 +153,7 @@ class StartRemoteEngineDialog : public QDialog
public: public:
explicit StartRemoteEngineDialog(QWidget *parent); explicit StartRemoteEngineDialog(QWidget *parent);
~StartRemoteEngineDialog(); ~StartRemoteEngineDialog() override;
QString username() const; QString username() const;
QString host() const; QString host() const;
QString password() const; QString password() const;
@@ -172,7 +172,7 @@ class TypeFormatsDialog : public QDialog
public: public:
explicit TypeFormatsDialog(QWidget *parent); explicit TypeFormatsDialog(QWidget *parent);
~TypeFormatsDialog(); ~TypeFormatsDialog() override;
void addTypeFormats(const QString &type, const DisplayFormats &formats, void addTypeFormats(const QString &type, const DisplayFormats &formats,
int currentFormat); int currentFormat);

View File

@@ -237,7 +237,7 @@ class DebuggerEngine : public QObject
public: public:
explicit DebuggerEngine(); explicit DebuggerEngine();
virtual ~DebuggerEngine(); ~DebuggerEngine() override;
const DebuggerRunParameters &runParameters() const; const DebuggerRunParameters &runParameters() const;

View File

@@ -45,7 +45,7 @@ class DEBUGGER_EXPORT DebuggerItemManager : public QObject
public: public:
DebuggerItemManager(); DebuggerItemManager();
~DebuggerItemManager(); ~DebuggerItemManager() override;
static QList<DebuggerItem> debuggers(); static QList<DebuggerItem> debuggers();

View File

@@ -40,7 +40,7 @@ class DebuggerPlugin : public ExtensionSystem::IPlugin
public: public:
DebuggerPlugin(); DebuggerPlugin();
~DebuggerPlugin(); ~DebuggerPlugin() override;
static DebuggerPlugin *instance(); static DebuggerPlugin *instance();

View File

@@ -49,7 +49,7 @@ public:
explicit DebuggerRunTool(ProjectExplorer::RunControl *runControl, explicit DebuggerRunTool(ProjectExplorer::RunControl *runControl,
ProjectExplorer::Kit *kit = nullptr, ProjectExplorer::Kit *kit = nullptr,
bool allowTerminal = true); bool allowTerminal = true);
~DebuggerRunTool(); ~DebuggerRunTool() override;
Internal::DebuggerEngine *engine() const { return m_engine; } Internal::DebuggerEngine *engine() const { return m_engine; }
Internal::DebuggerEngine *activeEngine() const; Internal::DebuggerEngine *activeEngine() const;
@@ -154,7 +154,7 @@ class DEBUGGER_EXPORT GdbServerPortsGatherer : public ProjectExplorer::ChannelPr
public: public:
explicit GdbServerPortsGatherer(ProjectExplorer::RunControl *runControl); explicit GdbServerPortsGatherer(ProjectExplorer::RunControl *runControl);
~GdbServerPortsGatherer(); ~GdbServerPortsGatherer() override;
void setUseGdbServer(bool useIt) { m_useGdbServer = useIt; } void setUseGdbServer(bool useIt) { m_useGdbServer = useIt; }
bool useGdbServer() const { return m_useGdbServer; } bool useGdbServer() const { return m_useGdbServer; }
@@ -182,7 +182,7 @@ public:
explicit GdbServerRunner(ProjectExplorer::RunControl *runControl, explicit GdbServerRunner(ProjectExplorer::RunControl *runControl,
GdbServerPortsGatherer *portsGatherer); GdbServerPortsGatherer *portsGatherer);
~GdbServerRunner(); ~GdbServerRunner() override;
void setRunnable(const ProjectExplorer::StandardRunnable &runnable); void setRunnable(const ProjectExplorer::StandardRunnable &runnable);
void setUseMulti(bool on); void setUseMulti(bool on);

View File

@@ -75,7 +75,7 @@ class DebuggerToolTipManager : public QObject
public: public:
DebuggerToolTipManager(); DebuggerToolTipManager();
~DebuggerToolTipManager(); ~DebuggerToolTipManager() override;
static void registerEngine(DebuggerEngine *engine); static void registerEngine(DebuggerEngine *engine);
static void deregisterEngine(DebuggerEngine *engine); static void deregisterEngine(DebuggerEngine *engine);
@@ -84,7 +84,7 @@ public:
static DebuggerToolTipContexts pendingTooltips(DebuggerEngine *engine); static DebuggerToolTipContexts pendingTooltips(DebuggerEngine *engine);
virtual bool eventFilter(QObject *, QEvent *); bool eventFilter(QObject *, QEvent *) override;
void debugModeEntered(); void debugModeEntered();
void leavingDebugMode(); void leavingDebugMode();

View File

@@ -43,7 +43,7 @@ class DisassemblerAgent : public QObject
public: public:
// Called from Gui // Called from Gui
explicit DisassemblerAgent(DebuggerEngine *engine); explicit DisassemblerAgent(DebuggerEngine *engine);
~DisassemblerAgent(); ~DisassemblerAgent() override;
void setLocation(const Location &location); void setLocation(const Location &location);
const Location &location() const; const Location &location() const;

View File

@@ -74,7 +74,7 @@ class MemoryAgent : public QObject
public: public:
MemoryAgent(const MemoryViewSetupData &data, DebuggerEngine *engine); MemoryAgent(const MemoryViewSetupData &data, DebuggerEngine *engine);
~MemoryAgent(); ~MemoryAgent() override;
void updateContents(); void updateContents();
void addData(quint64 address, const QByteArray &data); void addData(quint64 address, const QByteArray &data);

View File

@@ -118,7 +118,7 @@ class ModulesHandler : public QObject
public: public:
explicit ModulesHandler(DebuggerEngine *engine); explicit ModulesHandler(DebuggerEngine *engine);
~ModulesHandler(); ~ModulesHandler() override;
QAbstractItemModel *model() const; QAbstractItemModel *model() const;

View File

@@ -53,7 +53,7 @@ public:
void setPath(const QString &p); void setPath(const QString &p);
QString path() const; QString path() const;
virtual void accept(); void accept() override;
private: private:
Utils::PathChooser *m_chooser; Utils::PathChooser *m_chooser;

View File

@@ -52,7 +52,7 @@ class StackHandler : public QAbstractTableModel
public: public:
explicit StackHandler(DebuggerEngine *engine); explicit StackHandler(DebuggerEngine *engine);
~StackHandler(); ~StackHandler() override;
void setFrames(const StackFrames &frames, bool canExpand = false); void setFrames(const StackFrames &frames, bool canExpand = false);
void setFramesAndCurrentIndex(const GdbMi &frames, bool isFull); void setFramesAndCurrentIndex(const GdbMi &frames, bool isFull);

View File

@@ -82,8 +82,8 @@ public:
private: private:
void updateThreadBox(); void updateThreadBox();
void sort(int column, Qt::SortOrder order); void sort(int column, Qt::SortOrder order) override;
bool setData(const QModelIndex &idx, const QVariant &data, int role); bool setData(const QModelIndex &idx, const QVariant &data, int role) override;
DebuggerEngine *m_engine; DebuggerEngine *m_engine;
ThreadId m_currentId; ThreadId m_currentId;

View File

@@ -60,7 +60,7 @@ class WatchHandler : public QObject
public: public:
explicit WatchHandler(DebuggerEngine *engine); explicit WatchHandler(DebuggerEngine *engine);
~WatchHandler(); ~WatchHandler() override;
WatchModelBase *model() const; WatchModelBase *model() const;

View File

@@ -40,8 +40,8 @@ public:
explicit WatchTreeView(WatchType type); explicit WatchTreeView(WatchType type);
WatchType type() const { return m_type; } WatchType type() const { return m_type; }
void setModel(QAbstractItemModel *model); void setModel(QAbstractItemModel *model) override;
void reset(); void reset() override;
static void reexpand(QTreeView *view, const QModelIndex &idx); static void reexpand(QTreeView *view, const QModelIndex &idx);
@@ -58,8 +58,8 @@ private:
void collapseNode(const QModelIndex &idx); void collapseNode(const QModelIndex &idx);
void adjustSlider(); void adjustSlider();
void doItemsLayout(); void doItemsLayout() override;
void currentChanged(const QModelIndex &current, const QModelIndex &previous); void currentChanged(const QModelIndex &current, const QModelIndex &previous) override;
WatchType m_type; WatchType m_type;
int m_sliderPosition; int m_sliderPosition;