feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Implement effect maker preview zoom controls

Browse Source 
Also fix a memory leak on removing a node.

Fixes: QDS-10546
Change-Id: Ifc32b6d7f6f4c6b8ce63a080b159c8ae66865a79
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Amr Elsayed <amr.elsayed@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This commit is contained in:
Mahmoud Badri
2023-08-29 23:08:43 +03:00
parent 939b28a076
commit 2f2d8bf9e8
2 changed files with 38 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/effectmaker/effectmakermodel.cpp
View File

@@ -48,7 +48,9 @@ void EffectMakerModel::addNode(const QString &nodeQenPath)
void EffectMakerModel::removeNode(int idx)
{
beginRemoveRows({}, idx, idx);
CompositionNode *node = m_nodes.at(idx);
m_nodes.removeAt(idx);
delete node;
endRemoveRows();
}