feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Tracing: Avoid copying unneeded parts of a Icon

Browse Source 
Change-Id: I975fea87ce94661cbc61caa08d3da5bb6596cf26
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2022-08-03 14:14:20 +02:00
parent d24dd97717
commit 2f37566f33
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/libs/tracing/timelinetheme.cpp
View File

@@ -61,38 +61,38 @@ public:
&& idElements.at(1) == QLatin1String("disabled")) && idElements.at(1) == QLatin1String("disabled"))
? QIcon::Disabled : QIcon::Normal; ? QIcon::Disabled : QIcon::Normal;
Icon icon; QIcon icon;
if (iconName == "prev") if (iconName == "prev")
icon = Icons::PREV_TOOLBAR; icon = Icons::PREV_TOOLBAR.icon();
else if (iconName == "next") else if (iconName == "next")
icon = Icons::NEXT_TOOLBAR; icon = Icons::NEXT_TOOLBAR.icon();
else if (iconName == "zoom") else if (iconName == "zoom")
icon = Icons::ZOOM_TOOLBAR; icon = Icons::ZOOM_TOOLBAR.icon();
else if (iconName == "rangeselection") else if (iconName == "rangeselection")
icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_rangeselection.png", Theme::IconsBaseColor}}); icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_rangeselection.png", Theme::IconsBaseColor}}).icon();
else if (iconName == "rangeselected") else if (iconName == "rangeselected")
icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_rangeselected.png", Theme::IconsBaseColor}}); icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_rangeselected.png", Theme::IconsBaseColor}}).icon();
else if (iconName == "selectionmode") else if (iconName == "selectionmode")
icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_selectionmode.png", Theme::IconsBaseColor}}); icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_selectionmode.png", Theme::IconsBaseColor}}).icon();
else if (iconName == "edit") else if (iconName == "edit")
icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_edit.png", Theme::IconsBaseColor}}); icon = Icon({{":/qt/qml/QtCreator/Tracing/ico_edit.png", Theme::IconsBaseColor}}).icon();
else if (iconName == "lock_open") else if (iconName == "lock_open")
icon = Icons::UNLOCKED_TOOLBAR; icon = Icons::UNLOCKED_TOOLBAR.icon();
else if (iconName == "lock_closed") else if (iconName == "lock_closed")
icon = Icons::LOCKED_TOOLBAR; icon = Icons::LOCKED_TOOLBAR.icon();
else if (iconName == "range_handle") else if (iconName == "range_handle")
icon = Icon({{":/qt/qml/QtCreator/Tracing/range_handle.png", Theme::IconsBaseColor}}); icon = Icon({{":/qt/qml/QtCreator/Tracing/range_handle.png", Theme::IconsBaseColor}}).icon();
else if (iconName == "note") else if (iconName == "note")
icon = Icons::INFO_TOOLBAR; icon = Icons::INFO_TOOLBAR.icon();
else if (iconName == "split") else if (iconName == "split")
icon = Icons::SPLIT_HORIZONTAL_TOOLBAR; icon = Icons::SPLIT_HORIZONTAL_TOOLBAR.icon();
else if (iconName == "close_split") else if (iconName == "close_split")
icon = Icons::CLOSE_SPLIT_TOP; icon = Icons::CLOSE_SPLIT_TOP.icon();
else if (iconName == "close_window") else if (iconName == "close_window")
icon = Icons::CLOSE_TOOLBAR; icon = Icons::CLOSE_TOOLBAR.icon();
const QSize iconSize(16, 16); const QSize iconSize(16, 16);
const QPixmap result = icon.icon().pixmap(iconSize, iconMode); const QPixmap result = icon.pixmap(iconSize, iconMode);
if (size) if (size)
*size = result.size(); *size = result.size();