feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppElementEvaluator: Remove not very useful method

Browse Source 
Change-Id: I73545f6366e0f8ca856e15dc4ea28603351a93f1
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2024-02-03 01:18:55 +01:00
parent 90c227b034
commit 2f81936218
3 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cppeditor/cppbuiltinmodelmanagersupport.cpp
View File

@@ -56,8 +56,8 @@ private:
} }
const FilePath filePath = editorWidget->textDocument()->filePath(); const FilePath filePath = editorWidget->textDocument()->filePath();
const QStringList fallback = identifierWordsUnderCursor(tc); const QStringList fallback = identifierWordsUnderCursor(tc);
if (evaluator.identifiedCppElement()) { const std::shared_ptr<CppElement> &cppElement = evaluator.cppElement();
const std::shared_ptr<CppElement> &cppElement = evaluator.cppElement(); if (cppElement) {
const QStringList candidates = cppElement->helpIdCandidates; const QStringList candidates = cppElement->helpIdCandidates;
const HelpItem helpItem(candidates + fallback, const HelpItem helpItem(candidates + fallback,
filePath, filePath,

5
src/plugins/cppeditor/cppelementevaluator.cpp
View File

@@ -672,11 +672,6 @@ void CppElementEvaluator::execute()
exec(std::ref(d->m_functor), std::bind(&FromGuiFunctor::syncExec, &d->m_functor, _1, _2, _3), false); exec(std::ref(d->m_functor), std::bind(&FromGuiFunctor::syncExec, &d->m_functor, _1, _2, _3), false);
} }
bool CppElementEvaluator::identifiedCppElement() const
{
return bool(d->m_functor.m_element);
}
const std::shared_ptr<CppElement> &CppElementEvaluator::cppElement() const const std::shared_ptr<CppElement> &CppElementEvaluator::cppElement() const
{ {
return d->m_functor.m_element; return d->m_functor.m_element;

1
src/plugins/cppeditor/cppelementevaluator.h
View File

@@ -41,7 +41,6 @@ public:
static QFuture<std::shared_ptr<CppElement>> asyncExecute(TextEditor::TextEditorWidget *editor); static QFuture<std::shared_ptr<CppElement>> asyncExecute(TextEditor::TextEditorWidget *editor);
static QFuture<std::shared_ptr<CppElement>> asyncExecute(const QString &expression, static QFuture<std::shared_ptr<CppElement>> asyncExecute(const QString &expression,
const Utils::FilePath &filePath); const Utils::FilePath &filePath);
bool identifiedCppElement() const;
const std::shared_ptr<CppElement> &cppElement() const; const std::shared_ptr<CppElement> &cppElement() const;
bool hasDiagnosis() const; bool hasDiagnosis() const;
const QString &diagnosis() const; const QString &diagnosis() const;