feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SSH: SshRemoteProcessRunner does not need to be a shared pointer.

Browse Source 
Change-Id: I49cf2e113d23ebebe0939adbf90a1a88c84998a5
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
This commit is contained in:
Christian Kandeler
2011-10-28 16:10:26 +02:00
parent c8fc9b33ae
commit 2faf3b2548
18 changed files with 145 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/libs/utils/ssh/sshremoteprocessrunner.cpp
View File

@@ -234,24 +234,16 @@ void SshRemoteProcessRunnerPrivate::assertState(State allowedState,
} // namespace Internal
SshRemoteProcessRunner::Ptr SshRemoteProcessRunner::create(const SshConnectionParameters &params)
{
return SshRemoteProcessRunner::Ptr(new SshRemoteProcessRunner(params));
}
SshRemoteProcessRunner::Ptr SshRemoteProcessRunner::create(const SshConnection::Ptr &connection)
{
return SshRemoteProcessRunner::Ptr(new SshRemoteProcessRunner(connection));
}
SshRemoteProcessRunner::SshRemoteProcessRunner(const SshConnectionParameters &params)
: d(new Internal::SshRemoteProcessRunnerPrivate(params, this))
SshRemoteProcessRunner::SshRemoteProcessRunner(const SshConnectionParameters &params,
QObject *parent)
: QObject(parent), d(new Internal::SshRemoteProcessRunnerPrivate(params, this))
{
init();
}
SshRemoteProcessRunner::SshRemoteProcessRunner(const SshConnection::Ptr &connection)
: d(new Internal::SshRemoteProcessRunnerPrivate(connection, this))
SshRemoteProcessRunner::SshRemoteProcessRunner(const SshConnection::Ptr &connection,
QObject *parent)
: QObject(parent), d(new Internal::SshRemoteProcessRunnerPrivate(connection, this))
{
init();
}

8
src/libs/utils/ssh/sshremoteprocessrunner.h
View File

@@ -46,10 +46,8 @@ class QTCREATOR_UTILS_EXPORT SshRemoteProcessRunner : public QObject
Q_OBJECT
public:
typedef QSharedPointer<SshRemoteProcessRunner> Ptr;
static Ptr create(const SshConnectionParameters &params);
static Ptr create(const SshConnection::Ptr &connection);
SshRemoteProcessRunner(const SshConnectionParameters &params, QObject *parent = 0);
SshRemoteProcessRunner(const SshConnection::Ptr &connection, QObject *parent = 0);
void run(const QByteArray &command);
void runInTerminal(const QByteArray &command,
@@ -67,8 +65,6 @@ signals:
void processClosed(int exitStatus); // values are of type SshRemoteProcess::ExitStatus
private:
SshRemoteProcessRunner(const SshConnectionParameters &params);
SshRemoteProcessRunner(const SshConnection::Ptr &connection);
void init();
Internal::SshRemoteProcessRunnerPrivate *d;