feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

SSH: SshRemoteProcessRunner does not need to be a shared pointer.

Browse Source 
Change-Id: I49cf2e113d23ebebe0939adbf90a1a88c84998a5
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
This commit is contained in:
Christian Kandeler
2011-10-28 16:10:26 +02:00
parent c8fc9b33ae
commit 2faf3b2548
18 changed files with 145 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/remotelinux/startgdbserverdialog.cpp
View File

@@ -53,10 +53,7 @@ namespace Internal {
class StartGdbServerDialogPrivate
{
public:
StartGdbServerDialogPrivate()
: processList(0)
{}
StartGdbServerDialogPrivate() : processList(0), runner(0) {}
LinuxDeviceConfiguration::ConstPtr currentDevice() const
{
@@ -68,7 +65,7 @@ public:
QSortFilterProxyModel proxyModel;
Ui::StartGdbServerDialog ui;
RemoteLinuxUsedPortsGatherer gatherer;
Utils::SshRemoteProcessRunner::Ptr runner;
Utils::SshRemoteProcessRunner *runner;
};
} // namespace Internal
@@ -241,17 +238,16 @@ void StartGdbServerDialog::handleProcessClosed(int status)
void StartGdbServerDialog::startGdbServerOnPort(int port, int pid)
{
LinuxDeviceConfiguration::ConstPtr device = d->currentDevice();
d->runner = Utils::SshRemoteProcessRunner::create(device->sshParameters());
connect(d->runner.data(), SIGNAL(connectionError(Utils::SshError)),
delete d->runner;
d->runner = new Utils::SshRemoteProcessRunner(device->sshParameters(), this);
connect(d->runner, SIGNAL(connectionError(Utils::SshError)),
SLOT(handleConnectionError()));
connect(d->runner.data(), SIGNAL(processStarted()),
SLOT(handleProcessStarted()));
connect(d->runner.data(), SIGNAL(processOutputAvailable(QByteArray)),
connect(d->runner, SIGNAL(processStarted()), SLOT(handleProcessStarted()));
connect(d->runner, SIGNAL(processOutputAvailable(QByteArray)),
SLOT(handleProcessOutputAvailable(QByteArray)));
connect(d->runner.data(), SIGNAL(processErrorOutputAvailable(QByteArray)),
connect(d->runner, SIGNAL(processErrorOutputAvailable(QByteArray)),
SLOT(handleProcessErrorOutput(QByteArray)));
connect(d->runner.data(), SIGNAL(processClosed(int)),
SLOT(handleProcessClosed(int)));
connect(d->runner, SIGNAL(processClosed(int)), SLOT(handleProcessClosed(int)));
QByteArray cmd = "/usr/bin/gdbserver --attach localhost:"
+ QByteArray::number(port) + " " + QByteArray::number(pid);