CMake: Split build output into lines before parsing

This amends commit b15d1951a2, where we moved the line splitting into
the output parsers, but overlooked that the CMakeBuildStep does
additional line-based parsing. As a result, the stdout -> stderr
redirection for ninja output was broken.

Change-Id: Iafbbce9a3f9c0383812a9e4c129c1d94fa907b73
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/cmakeprojectmanager/cmakebuildstep.cpp

@@ -268,15 +268,26 @@ QString CMakeBuildStep::defaultBuildTarget() const
     return allTarget();
 }
 
-void CMakeBuildStep::stdOutput(const QString &line)
+void CMakeBuildStep::stdOutput(const QString &output)
 {
+    int offset = 0;
+    while (offset != -1) {
+        const int newlinePos = output.indexOf('\n', offset);
+        QString line;
+        if (newlinePos == -1) {
+            line = output.mid(offset);
+            offset = -1;
+        } else {
+            line = output.mid(offset, newlinePos - offset + 1);
+            offset = newlinePos + 1;
+        }
         if (m_percentProgress.indexIn(line) != -1) {
             AbstractProcessStep::stdOutput(line);
             bool ok = false;
             int percent = m_percentProgress.cap(1).toInt(&ok);
             if (ok)
                 emit progress(percent, QString());
-        return;
+            continue;
         } else if (m_ninjaProgress.indexIn(line) != -1) {
             AbstractProcessStep::stdOutput(line);
             m_useNinja = true;
@@ -289,13 +300,14 @@ void CMakeBuildStep::stdOutput(const QString &line)
                     emit progress(percent, QString());
                 }
             }
-        return;
+            continue;
         }
         if (m_useNinja)
             AbstractProcessStep::stdError(line);
         else
             AbstractProcessStep::stdOutput(line);
     }
+}
 
 QString CMakeBuildStep::buildTarget() const
 {

src/plugins/cmakeprojectmanager/cmakebuildstep.h

@@ -77,7 +77,7 @@ protected:
     bool fromMap(const QVariantMap &map) override;
 
     // For parsing [ 76%]
-    void stdOutput(const QString &line) override;
+    void stdOutput(const QString &output) override;
 
 private:
     void ctor(ProjectExplorer::BuildStepList *bsl);