feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Check (build|run)configurations on addition

Browse Source 
* Make sure we do not add duplicate or 0 (build|run)configurations
   to a project.

Reviewed-by: dt
This commit is contained in:
Tobias Hunger
2010-01-15 10:54:29 +01:00
parent 95666a2e66
commit 3061d7dc32
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/projectexplorer/project.cpp
View File

@@ -83,6 +83,8 @@ QString Project::makeUnique(const QString &preferredName, const QStringList &use
void Project::addBuildConfiguration(BuildConfiguration *configuration) void Project::addBuildConfiguration(BuildConfiguration *configuration)
{ {
QTC_ASSERT(!configuration || m_buildConfigurations.contains(configuration), return);
// Check that we don't have a configuration with the same displayName // Check that we don't have a configuration with the same displayName
QString configurationDisplayName = configuration->displayName(); QString configurationDisplayName = configuration->displayName();
QStringList displayNames; QStringList displayNames;
@@ -413,10 +415,8 @@ QList<RunConfiguration *> Project::runConfigurations() const
void Project::addRunConfiguration(RunConfiguration* runConfiguration) void Project::addRunConfiguration(RunConfiguration* runConfiguration)
{ {
if (m_runConfigurations.contains(runConfiguration)) { QTC_ASSERT(!runConfiguration || m_runConfigurations.contains(runConfiguration), return);
qWarning()<<"Not adding already existing runConfiguration"<<runConfiguration->displayName();
return;
}
m_runConfigurations.push_back(runConfiguration); m_runConfigurations.push_back(runConfiguration);
emit addedRunConfiguration(this, runConfiguration->displayName()); emit addedRunConfiguration(this, runConfiguration->displayName());
} }