Add missing "final" to unexported/unshared classes

Change-Id: I84d5fc39d7ef5588a20545854d0cfd0b993db090
Reviewed-by: hjk <hjk@qt.io>

src/plugins/android/createandroidmanifestwizard.cpp

@@ -145,8 +145,8 @@ public:
     ChooseDirectoryPage(CreateAndroidManifestWizard *wizard);
 
 private:
-    void initializePage();
-    bool isComplete() const;
+    void initializePage() final;
+    bool isComplete() const final;
     void checkPackageSourceDir();
 
     CreateAndroidManifestWizard *m_wizard;

src/plugins/autotest/testresultspane.h

@@ -69,7 +69,7 @@ signals:
     void copyShortcutTriggered();
 
 protected:
-    void keyPressEvent(QKeyEvent *event);
+    void keyPressEvent(QKeyEvent *event) final;
 };
 
 class TestResultsPane : public Core::IOutputPane

src/plugins/autotest/testtreemodel.h

@@ -134,8 +134,8 @@ public:
     static FilterMode toFilterMode(int f);
 
 protected:
-    bool lessThan(const QModelIndex &left, const QModelIndex &right) const;
-    bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const;
+    bool lessThan(const QModelIndex &left, const QModelIndex &right) const final;
+    bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const final;
 
 private:
     Autotest::TestTreeItem::SortMode m_sortMode = Autotest::TestTreeItem::Alphabetically;

src/plugins/boot2qt/qdbmakedefaultappservice.h

@@ -44,12 +44,12 @@ private:
     void handleStdErr();
     void handleProcessFinished(const QString &error);
 
-    bool isDeploymentNecessary() const { return true; }
-    void doDeviceSetup() { handleDeviceSetupDone(true); }
-    void stopDeviceSetup() { handleDeviceSetupDone(false); }
+    bool isDeploymentNecessary() const final { return true; }
+    void doDeviceSetup() final { handleDeviceSetupDone(true); }
+    void stopDeviceSetup() final { handleDeviceSetupDone(false); }
 
-    void doDeploy();
-    void stopDeployment();
+    void doDeploy() final;
+    void stopDeployment() final;
 
     void cleanup();
 

src/plugins/clangtools/clangtool.cpp

@@ -188,7 +188,7 @@ class SelectFixitsCheckBox : public QCheckBox
     Q_OBJECT
 
 private:
-    void nextCheckState() final override
+    void nextCheckState() final
     {
         setCheckState(checkState() == Qt::Checked ? Qt::Unchecked : Qt::Checked);
     }

src/plugins/cmakeprojectmanager/cmakeprojectplugin.h

@@ -57,8 +57,8 @@ private slots:
 #endif
 
 private:
-    bool initialize(const QStringList &arguments, QString *errorMessage);
-    void extensionsInitialized();
+    bool initialize(const QStringList &arguments, QString *errorMessage) final;
+    void extensionsInitialized() final;
 
     void updateContextActions();
 

src/plugins/coreplugin/plugininstallwizard.cpp

@@ -130,7 +130,7 @@ public:
         emit completeChanged();
     }
 
-    bool isComplete() const
+    bool isComplete() const final
     {
         const FilePath path = m_data->sourcePath;
         if (!QFile::exists(path.toString())) {
@@ -148,7 +148,7 @@ public:
         return true;
     }
 
-    int nextId() const
+    int nextId() const final
     {
         if (hasLibSuffix(m_data->sourcePath))
             return WizardPage::nextId() + 1; // jump over check archive
@@ -192,7 +192,7 @@ public:
         vlayout->addWidget(m_output);
     }
 
-    void initializePage()
+    void initializePage() final
     {
         m_isComplete = false;
         emit completeChanged();
@@ -303,7 +303,7 @@ public:
                          InfoLabel::Error});
     }
 
-    void cleanupPage()
+    void cleanupPage() final
     {
         // back button pressed
         m_cancelButton->disconnect();
@@ -319,7 +319,7 @@ public:
         m_tempDir.reset();
     }
 
-    bool isComplete() const { return m_isComplete; }
+    bool isComplete() const final { return m_isComplete; }
 
     std::unique_ptr<TemporaryDirectory> m_tempDir;
     Archive *m_archive = nullptr;
@@ -402,7 +402,7 @@ public:
         vlayout->addWidget(m_summaryLabel);
     }
 
-    void initializePage()
+    void initializePage() final
     {
         m_summaryLabel->setText(
             PluginInstallWizard::tr("\"%1\" will be installed into \"%2\".")

src/plugins/cpptools/clangdiagnosticconfigswidget.cpp

@@ -62,8 +62,8 @@ public:
         : Utils::StaticTreeItem(text)
     {}
 
-    Qt::ItemFlags flags(int) const { return {}; }
-    QVariant data(int column, int role) const
+    Qt::ItemFlags flags(int) const final { return {}; }
+    QVariant data(int column, int role) const final
     {
         if (role == Qt::ForegroundRole) {
             // Avoid disabled color.

src/plugins/debugger/commonoptionspage.cpp

@@ -385,8 +385,8 @@ public:
         m_group.insert(action(MaximalStringLength), spinBoxMaximalStringLength);
     }
 
-    void apply() { m_group.apply(ICore::settings()); }
-    void finish() { m_group.finish(); }
+    void apply() final { m_group.apply(ICore::settings()); }
+    void finish() final { m_group.finish(); }
 
 private:
     Utils::SavedActionSet m_group;

src/plugins/debugger/gdb/gdbengine.h

@@ -204,7 +204,7 @@ private: ////////// General Interface //////////
     void executeRunToFunction(const QString &functionName) final;
     void executeJumpToLine(const ContextData &data) final;
     void executeReturn() final;
-    void executeRecordReverse(bool reverse);
+    void executeRecordReverse(bool reverse) final;
 
     void handleExecuteContinue(const DebuggerResponse &response);
     void handleExecuteStep(const DebuggerResponse &response);

src/plugins/designer/cpp/formclasswizard.h

@@ -44,9 +44,9 @@ public:
     QString formSuffix() const;
 
 private:
-    Core::BaseFileWizard *create(QWidget *parent, const Core::WizardDialogParameters &parameters) const;
+    Core::BaseFileWizard *create(QWidget *parent, const Core::WizardDialogParameters &parameters) const final;
 
-    Core::GeneratedFiles generateFiles(const QWizard *w, QString *errorMessage) const;
+    Core::GeneratedFiles generateFiles(const QWizard *w, QString *errorMessage) const final;
 };
 
 } // namespace Internal

src/plugins/designer/cpp/formclasswizarddialog.h

@@ -50,10 +50,10 @@ public:
 
     Designer::FormClassWizardParameters parameters() const;
 
-    bool validateCurrentPage();
+    bool validateCurrentPage() final;
 
 protected:
-    void initializePage(int id);
+    void initializePage(int id) final;
 
 private:
     FormTemplateWizardPage *m_formPage = nullptr;

src/plugins/ios/iosbuildstep.cpp

@@ -78,7 +78,7 @@ private:
     Utils::FilePath buildCommand() const;
 
     bool init() final;
-    void setupOutputFormatter(Utils::OutputFormatter *formatter);
+    void setupOutputFormatter(Utils::OutputFormatter *formatter) final;
     void doRun() final;
     bool fromMap(const QVariantMap &map) final;
     QVariantMap toMap() const final;

src/plugins/ios/iosdevice.cpp

@@ -98,7 +98,7 @@ class IosDeviceInfoWidget : public IDeviceWidget
 public:
     IosDeviceInfoWidget(const ProjectExplorer::IDevice::Ptr &device);
 
-    void updateDeviceFromUi() {}
+    void updateDeviceFromUi() final {}
 };
 
 IosDevice::IosDevice(CtorHelper)

src/plugins/mesonprojectmanager/project/mesonprojectimporter.h

@@ -51,7 +51,7 @@ private:
     // will get one of the results from examineDirectory
     const QList<ProjectExplorer::BuildInfo> buildInfoList(void *directoryData) const final;
 
-    virtual void deleteDirectoryData(void *directoryData) const final;
+    void deleteDirectoryData(void *directoryData) const final;
 };
 
 } // namespace Internal

src/plugins/modeleditor/componentviewcontroller.cpp

@@ -60,7 +60,7 @@ class FindComponentFromFilePath :
 public:
     void setFilePath(const QString &filePath);
     qmt::MComponent *component() const { return m_bestComponent; }
-    void visitMComponent(qmt::MComponent *component);
+    void visitMComponent(qmt::MComponent *component) final;
 
 private:
     QString m_elementName;
@@ -122,7 +122,7 @@ public:
     void setModelController(qmt::ModelController *modelController);
     void setModelUtilities(ModelUtilities *modelUtilities);
     void updateFilePaths();
-    void visitMComponent(qmt::MComponent *component);
+    void visitMComponent(qmt::MComponent *component) final;
 
 private:
     QStringList findFilePathOfComponent(const qmt::MComponent *component);

src/plugins/modeleditor/modelindexer.cpp

@@ -201,8 +201,8 @@ class ModelIndexer::DiagramsCollectorVisitor :
 public:
     DiagramsCollectorVisitor(ModelIndexer::IndexedModel *indexedModel);
 
-    void visitMObject(const qmt::MObject *object);
-    void visitMDiagram(const qmt::MDiagram *diagram);
+    void visitMObject(const qmt::MObject *object) final;
+    void visitMDiagram(const qmt::MDiagram *diagram) final;
 
 private:
     ModelIndexer::IndexedModel *m_indexedModel;

src/plugins/nim/editor/nimcompletionassistprovider.cpp

@@ -91,7 +91,7 @@ public:
         return nullptr;
     }
 
-    bool running()
+    bool running() final
     {
         return m_running;
     }

src/plugins/perfprofiler/perfprofilerstatisticsmodel.h

@@ -63,8 +63,8 @@ public:
         uint occurrences;
     };
 
-    int columnCount(const QModelIndex &parent) const;
-    QVariant headerData(int section, Qt::Orientation orientation, int role) const;
+    int columnCount(const QModelIndex &parent) const final;
+    QVariant headerData(int section, Qt::Orientation orientation, int role) const final;
     void resort();
 
 protected:
@@ -135,9 +135,9 @@ public:
 
     PerfProfilerStatisticsRelativesModel(Relation relation,
                                          PerfProfilerStatisticsMainModel *parent);
-    int rowCount(const QModelIndex &parent) const;
-    QVariant data(const QModelIndex &index, int role) const;
-    void sort(int column, Qt::SortOrder order);
+    int rowCount(const QModelIndex &parent) const final;
+    QVariant data(const QModelIndex &index, int role) const final;
+    void sort(int column, Qt::SortOrder order) final;
     void sortForInsert();
 
     void selectByTypeId(int typeId);

src/plugins/perfprofiler/perfprofilerstatisticsview.cpp

@@ -55,7 +55,7 @@ class HexNumberDelegate : public QStyledItemDelegate
 public:
     HexNumberDelegate(QObject *parent = nullptr) : QStyledItemDelegate(parent) {}
 
-    QString displayText(const QVariant &value, const QLocale &locale) const
+    QString displayText(const QVariant &value, const QLocale &locale) const final
     {
         Q_UNUSED(locale)
         return QString::fromLatin1("0x%1").arg(value.toULongLong(), 16, 16, QLatin1Char('0'));

src/plugins/projectexplorer/processstep.cpp

@@ -53,7 +53,7 @@ class ProcessStep final : public AbstractProcessStep
 public:
     ProcessStep(BuildStepList *bsl, Id id);
 
-    void setupOutputFormatter(OutputFormatter *formatter);
+    void setupOutputFormatter(OutputFormatter *formatter) final;
 };
 
 ProcessStep::ProcessStep(BuildStepList *bsl, Id id)

src/plugins/projectexplorer/projectwindow.cpp

@@ -356,13 +356,13 @@ private:
         return HostOsInfo::isWindowsHost() && e->button() == Qt::RightButton;
     }
 
-    void mousePressEvent(QMouseEvent *e)
+    void mousePressEvent(QMouseEvent *e) final
     {
         if (!userWantsContextMenu(e))
             BaseTreeView::mousePressEvent(e);
     }
 
-    void mouseReleaseEvent(QMouseEvent *e)
+    void mouseReleaseEvent(QMouseEvent *e) final
     {
         if (!userWantsContextMenu(e))
             BaseTreeView::mouseReleaseEvent(e);

src/plugins/projectexplorer/toolchainoptionspage.cpp

@@ -309,7 +309,7 @@ public:
 
     void redetectToolchains();
 
-    void apply();
+    void apply() final;
 
  private:
     TreeModel<TreeItem, ToolChainTreeItem> m_model;

src/plugins/qmldesigner/assetexporterplugin/assetexporterplugin.h

@@ -42,8 +42,8 @@ class AssetExporterPlugin : public QObject, QmlDesigner::IWidgetPlugin
 public:
     AssetExporterPlugin();
 
-    QString metaInfo() const;
-    QString pluginName() const;
+    QString metaInfo() const final;
+    QString pluginName() const final;
 
 private:
     void onExport();

src/plugins/qmldesigner/components/bindingeditor/bindingeditorwidget.h

@@ -70,9 +70,9 @@ public:
     ~BindingDocument();
 
 protected:
-    void applyFontSettings();
+    void applyFontSettings() final;
 
-    void triggerPendingUpdates();
+    void triggerPendingUpdates() final;
 
 private:
     QmlJSEditor::SemanticHighlighter *m_semanticHighlighter = nullptr;

src/plugins/qtsupport/qtoptionspage.cpp

@@ -103,7 +103,7 @@ public:
         return m_version;
     }
 
-    QVariant data(int column, int role) const
+    QVariant data(int column, int role) const final
     {
         if (!m_version)
             return TreeItem::data(column, role);