feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

macros: Remove foreach / Q_FOREACH usage

Browse Source 
Task-number: QTCREATORBUG-27464
Change-Id: Id779aaf869406571288519083883ab57e5c29cec
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Artem Sokolovskii
2022-06-02 14:23:03 +02:00
parent 7020b0a44a
commit 30e60e9979
14 changed files with 33 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/perforce/perforceplugin.cpp
View File

@@ -724,7 +724,8 @@ void PerforcePluginPrivate::printOpenedFileList()
QString errorMessage;
QString mapped;
const QChar delimiter = QLatin1Char('#');
foreach (const QString &line, perforceResponse.stdOut.split(QLatin1Char('\n'))) {
const QStringList lines = perforceResponse.stdOut.split(QLatin1Char('\n'));
for (const QString &line : lines) {
mapped.clear();
const int delimiterPos = line.indexOf(delimiter);
if (delimiterPos > 0)
@@ -787,9 +788,9 @@ void PerforcePluginPrivate::startSubmitProject()
return;
}
QStringList filesLines = filesResult.stdOut.split(QLatin1Char('\n'));
const QStringList filesLines = filesResult.stdOut.split(QLatin1Char('\n'));
QStringList depotFileNames;
foreach (const QString &line, filesLines) {
for (const QString &line : filesLines) {
depotFileNames.append(line.left(line.lastIndexOf(QRegularExpression("#[0-9]+\\s-\\s"))));
}
if (depotFileNames.isEmpty()) {