Header cleanup in QtSupport.

Change-Id: I681bab48aafb029f4869209382493dfa36233a2d
Reviewed-on: http://codereview.qt.nokia.com/3081
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>

src/plugins/qt4projectmanager/qt-s60/symbianqtversion.cpp

@@ -41,6 +41,7 @@
 #include <projectexplorer/toolchainmanager.h>
 #include <qtsupport/qtsupportconstants.h>
 #include <utils/pathchooser.h>
+#include <utils/environment.h>
 #include <proparser/profileevaluator.h>
 
 #include <QtCore/QCoreApplication>

src/plugins/qtsupport/baseqtversion.cpp

@@ -45,6 +45,7 @@
 #include <projectexplorer/toolchainmanager.h>
 #include <projectexplorer/persistentsettings.h>
 
+#include <utils/environment.h>
 #include <utils/synchronousprocess.h>
 
 #include <QtCore/QDir>

src/plugins/qtsupport/baseqtversion.h

@@ -38,10 +38,17 @@
 #include <projectexplorer/abi.h>
 #include <projectexplorer/headerpath.h>
 #include <projectexplorer/task.h>
-#include <projectexplorer/ioutputparser.h>
-#include <utils/environment.h>
 
 #include <QtCore/QVariantMap>
+#include <QtGui/QWidget>
+
+namespace Utils {
+class Environment;
+} // namespace Utils
+
+namespace ProjectExplorer {
+class IOutputParser;
+} // namespace ProjectExplorer
 
 QT_BEGIN_NAMESPACE
 class ProFileEvaluator;

src/plugins/qtsupport/debugginghelperbuildtask.cpp

@@ -39,6 +39,7 @@
 #include <coreplugin/messagemanager.h>
 #include <projectexplorer/abi.h>
 #include <projectexplorer/toolchainmanager.h>
+#include <projectexplorer/toolchain.h>
 #include <projectexplorer/debugginghelper.h>
 #include <projectexplorer/abi.h>
 #include <utils/qtcassert.h>

src/plugins/qtsupport/debugginghelperbuildtask.h

@@ -41,6 +41,10 @@
 #include <QtCore/QFutureInterface>
 #include <QtCore/QMetaType>
 
+namespace ProjectExplorer {
+class ToolChain;
+} // namespace ProjectExplorer
+
 namespace QtSupport {
 class BaseQtVersion;
 

src/plugins/qtsupport/gettingstartedwelcomepage.cpp

@@ -38,6 +38,7 @@
 #include <utils/fileutils.h>
 
 #include <coreplugin/coreplugin.h>
+#include <coreplugin/icore.h>
 #include <coreplugin/helpmanager.h>
 #include <projectexplorer/projectexplorer.h>
 
@@ -107,6 +108,11 @@ GettingStartedWelcomePage::GettingStartedWelcomePage()
 {
 }
 
+QUrl GettingStartedWelcomePage::pageLocation() const
+{
+    return QUrl::fromLocalFile(Core::ICore::instance()->resourcePath() + QLatin1String("/welcomescreen/gettingstarted.qml"));
+}
+
 void GettingStartedWelcomePage::facilitateQml(QDeclarativeEngine *engine)
 {
     m_engine = engine;

src/plugins/qtsupport/gettingstartedwelcomepage.h

@@ -34,10 +34,8 @@
 #define GETTINGSTARTEDWELCOMEPLUGIN_H
 
 #include <utils/iwelcomepage.h>
-#include <coreplugin/icore.h>
 
-#include <QtGui/QStringListModel>
+#include <QtCore/QStringList>
-#include <QtDeclarative/QDeclarativeItem>
 
 QT_BEGIN_NAMESPACE
 class QDeclarativeEngine;
@@ -57,7 +55,7 @@ class GettingStartedWelcomePage : public Utils::IWelcomePage
 public:
     GettingStartedWelcomePage();
 
-    QUrl pageLocation() const { return QUrl::fromLocalFile(Core::ICore::instance()->resourcePath() + QLatin1String("/welcomescreen/gettingstarted.qml")); }
+    QUrl pageLocation() const;
     QString title() const { return tr("Getting Started");}
     int priority() const { return 10; }
     void facilitateQml(QDeclarativeEngine *);

src/plugins/qtsupport/qtparser.cpp

@@ -39,10 +39,8 @@
 using namespace QtSupport;
 using ProjectExplorer::Task;
 
-namespace {
+// opt. drive letter + filename: (2 brackets)
-    // opt. drive letter + filename: (2 brackets)
+static const char FILE_PATTERN[] = "^(([A-Za-z]:)?[^:]+\\.[^:]+)";
-    const char * const FILE_PATTERN = "^(([A-Za-z]:)?[^:]+\\.[^:]+)";
-}
 
 QtParser::QtParser()
 {

src/plugins/qtsupport/qtversionfactory.cpp

@@ -33,6 +33,7 @@
 #include "qtversionfactory.h"
 #include "profilereader.h"
 #include "qtversionmanager.h"
+#include "baseqtversion.h"
 
 #include <extensionsystem/pluginmanager.h>
 #include <QtCore/QSettings>

src/plugins/qtsupport/qtversionfactory.h

@@ -33,14 +33,18 @@
 #ifndef QTVERSIONFACTORY_H
 #define QTVERSIONFACTORY_H
 
-#include "baseqtversion.h"
 #include "qtsupport_global.h"
 
 #include <QtCore/QObject>
 #include <QtCore/QVariantMap>
 
+QT_FORWARD_DECLARE_CLASS(QSettings)
+QT_FORWARD_DECLARE_CLASS(ProFileEvaluator)
+
 namespace QtSupport {
 
+class BaseQtVersion;
+
 class QTSUPPORT_EXPORT QtVersionFactory : public QObject
 {
     Q_OBJECT

src/plugins/qtsupport/qtversionmanager.h

@@ -36,14 +36,8 @@
 #include "qtsupport_global.h"
 #include "baseqtversion.h"
 
-#include <projectexplorer/abi.h>
-
-#include <QtCore/QHash>
 #include <QtCore/QSet>
-#include <QtCore/QSharedPointer>
-#include <QtCore/QFutureInterface>
 #include <QtCore/QStringList>
-#include <QtCore/QVariantMap>
 
 namespace Utils {
 class Environment;
@@ -56,8 +50,6 @@ class Task;
 }
 
 namespace QtSupport {
-class BaseQtVersion;
-
 namespace Internal {
 class QtOptionsPageWidget;
 class QtOptionsPage;

src/plugins/remotelinux/maemoqtversion.cpp

@@ -40,6 +40,7 @@
 #include <QtCore/QCoreApplication>
 #include <QtCore/QFile>
 #include <QtCore/QDir>
+#include <QtCore/QTextStream>
 
 using namespace Qt4ProjectManager;