feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakeProjectManager: Fix memory leaks

Browse Source 
Change-Id: Ie1d046a4d736b02db9465062784730ebbab6a2ed
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2020-01-23 11:28:56 +01:00
parent 51cc14c738
commit 314ceb13bc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/cmakeprojectmanager/cmakebuildsettingswidget.cpp
View File

@@ -86,8 +86,8 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
NamedWidget(tr("CMake")), NamedWidget(tr("CMake")),
m_buildConfiguration(bc), m_buildConfiguration(bc),
m_configModel(new ConfigModel(this)), m_configModel(new ConfigModel(this)),
m_configFilterModel(new Utils::CategorySortFilterModel), m_configFilterModel(new Utils::CategorySortFilterModel(this)),
m_configTextFilterModel(new Utils::CategorySortFilterModel) m_configTextFilterModel(new Utils::CategorySortFilterModel(this))
{ {
QTC_CHECK(bc); QTC_CHECK(bc);
@@ -106,7 +106,7 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
auto project = bc->project(); auto project = bc->project();
auto buildDirChooser = new Utils::PathChooser; auto buildDirChooser = new Utils::PathChooser(this);
buildDirChooser->setBaseDirectory(project->projectDirectory()); buildDirChooser->setBaseDirectory(project->projectDirectory());
buildDirChooser->setFileName(bc->buildDirectory()); buildDirChooser->setFileName(bc->buildDirectory());
connect(buildDirChooser, &Utils::PathChooser::rawPathChanged, this, connect(buildDirChooser, &Utils::PathChooser::rawPathChanged, this,
@@ -195,7 +195,7 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
m_addButton->setToolTip(tr("Add a new configuration value.")); m_addButton->setToolTip(tr("Add a new configuration value."));
buttonLayout->addWidget(m_addButton); buttonLayout->addWidget(m_addButton);
{ {
m_addButtonMenu = new QMenu; m_addButtonMenu = new QMenu(this);
m_addButtonMenu->addAction(tr("&Boolean"))->setData( m_addButtonMenu->addAction(tr("&Boolean"))->setData(
QVariant::fromValue(static_cast<int>(ConfigModel::DataItem::BOOLEAN))); QVariant::fromValue(static_cast<int>(ConfigModel::DataItem::BOOLEAN)));
m_addButtonMenu->addAction(tr("&String"))->setData( m_addButtonMenu->addAction(tr("&String"))->setData(