feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Prefer ProcessParameters::setCommandLine

Browse Source 
... over setting command and args individually.

Change-Id: Iec7c8d3a0b05fb8fa0639f7ddbe7ccdc7387d2a2
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-06-21 08:31:37 +02:00
parent 0d49c2cd2c
commit 3170601b4d
20 changed files with 122 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/nim/project/nimcompilerbuildstepconfigwidget.cpp
View File

@@ -34,6 +34,7 @@
#include <projectexplorer/processparameters.h>
#include <utils/qtcassert.h>
#include <utils/qtcprocess.h>
using namespace ProjectExplorer;
using namespace Utils;
@@ -103,16 +104,10 @@ void NimCompilerBuildStepConfigWidget::updateCommandLineText()
{
ProcessParameters *parameters = m_buildStep->processParameters();
QStringList command;
command << parameters->command().toString();
command << parameters->arguments();
const CommandLine cmd = parameters->command();
const QStringList parts = QtcProcess::splitArgs(cmd.toUserOutput());
// Remove empty args
auto predicate = [](const QString & str) { return str.isEmpty(); };
auto it = std::remove_if(command.begin(), command.end(), predicate);
command.erase(it, command.end());
m_ui->commandTextEdit->setText(command.join(QChar::LineFeed));
m_ui->commandTextEdit->setText(parts.join(QChar::LineFeed));
}
void NimCompilerBuildStepConfigWidget::updateTargetComboBox()