From 31749b76b83e3de392fcd80c2e2d11c71a36f25f Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Fri, 25 Nov 2016 16:56:56 +0100 Subject: [PATCH] Cmake: Don't take QStringRefs of a temporary QString This crashes. Change-Id: I3f81466f504fdff8d47372425ea8f84048f89b76 Reviewed-by: Orgad Shaneh --- src/plugins/cmakeprojectmanager/cmaketool.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmaketool.cpp b/src/plugins/cmakeprojectmanager/cmaketool.cpp index e38ce687484..acfb553e6a1 100644 --- a/src/plugins/cmakeprojectmanager/cmaketool.cpp +++ b/src/plugins/cmakeprojectmanager/cmaketool.cpp @@ -411,7 +411,8 @@ void CMakeTool::fetchVersionFromVersionOutput() const return; QRegularExpression versionLine("^cmake version ((\\d+).(\\d+).(\\d+).*)$"); - for (const QStringRef &line : response.stdOut().splitRef(QLatin1Char('\n'))) { + const QString responseText = response.stdOut(); + for (const QStringRef &line : responseText.splitRef(QLatin1Char('\n'))) { QRegularExpressionMatch match = versionLine.match(line); if (!match.hasMatch()) continue;