feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BuildStep: Hide some API in protected / private sections

Browse Source 
Change-Id: I3345afa871bbb900beb739b2a283145392262658
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2023-07-25 19:44:40 +02:00
parent 77cee300f6
commit 31cf0dfb74
2 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/buildstep.cpp
View File

@@ -241,11 +241,6 @@ QVariant BuildStep::data(Id id) const
return {}; return {};
} }
void BuildStep::addMacroExpander()
{
m_addMacroExpander = true;
}
void BuildStep::setEnabled(bool b) void BuildStep::setEnabled(bool b)
{ {
if (m_enabled == b) if (m_enabled == b)

31
src/plugins/projectexplorer/buildstep.h
View File

@@ -49,17 +49,10 @@ public:
BuildStepList *stepList() const; BuildStepList *stepList() const;
BuildConfiguration *buildConfiguration() const; BuildConfiguration *buildConfiguration() const;
DeployConfiguration *deployConfiguration() const;
ProjectConfiguration *projectConfiguration() const;
BuildSystem *buildSystem() const; BuildSystem *buildSystem() const;
Utils::Environment buildEnvironment() const;
Utils::FilePath buildDirectory() const;
BuildConfiguration::BuildType buildType() const; BuildConfiguration::BuildType buildType() const;
Utils::MacroExpander *macroExpander() const; Utils::MacroExpander *macroExpander() const;
QString fallbackWorkingDirectory() const;
virtual void setupOutputFormatter(Utils::OutputFormatter *formatter);
enum class OutputFormat { enum class OutputFormat {
Stdout, Stderr, // These are for forwarded output from external tools Stdout, Stderr, // These are for forwarded output from external tools
@@ -75,23 +68,12 @@ public:
}; };
bool widgetExpandedByDefault() const; bool widgetExpandedByDefault() const;
void setWidgetExpandedByDefault(bool widgetExpandedByDefault);
bool hasUserExpansionState() const { return m_wasExpanded.has_value(); } bool hasUserExpansionState() const { return m_wasExpanded.has_value(); }
bool wasUserExpanded() const { return m_wasExpanded.value_or(false); } bool wasUserExpanded() const { return m_wasExpanded.value_or(false); }
void setUserExpanded(bool expanded) { m_wasExpanded = expanded; } void setUserExpanded(bool expanded) { m_wasExpanded = expanded; }
bool isImmutable() const { return m_immutable; } bool isImmutable() const { return m_immutable; }
void setImmutable(bool immutable) { m_immutable = immutable; }
virtual QVariant data(Utils::Id id) const; virtual QVariant data(Utils::Id id) const;
void setSummaryUpdater(const std::function<QString()> &summaryUpdater);
void addMacroExpander();
QString summaryText() const; QString summaryText() const;
void setSummaryText(const QString &summaryText);
QWidget *doCreateConfigWidget(); QWidget *doCreateConfigWidget();
signals: signals:
@@ -112,11 +94,24 @@ signals:
void progress(int percentage, const QString &message); void progress(int percentage, const QString &message);
protected: protected:
void setWidgetExpandedByDefault(bool widgetExpandedByDefault);
void setImmutable(bool immutable) { m_immutable = immutable; }
void setSummaryUpdater(const std::function<QString()> &summaryUpdater);
void addMacroExpander() { m_addMacroExpander = true; }
void setSummaryText(const QString &summaryText);
DeployConfiguration *deployConfiguration() const;
Utils::Environment buildEnvironment() const;
Utils::FilePath buildDirectory() const;
QString fallbackWorkingDirectory() const;
virtual QWidget *createConfigWidget(); virtual QWidget *createConfigWidget();
virtual void setupOutputFormatter(Utils::OutputFormatter *formatter);
private: private:
friend class BuildManager; friend class BuildManager;
virtual Tasking::GroupItem runRecipe() = 0; virtual Tasking::GroupItem runRecipe() = 0;
ProjectConfiguration *projectConfiguration() const;
BuildStepList * const m_stepList; BuildStepList * const m_stepList;
bool m_enabled = true; bool m_enabled = true;