feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Inline some functions

Browse Source 
Change-Id: I923919f206f038cf8cedf709b4047cbc22a990ee
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Nikolai Kosjar
2018-01-03 14:18:08 +01:00
parent 91c50e797b
commit 31f61592e4
2 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/tools/clangbackend/source/clangcodemodelserver.cpp
View File

@@ -66,13 +66,14 @@ ClangCodeModelServer::ClangCodeModelServer()
QObject::connect(&updateVisibleButNotCurrentDocumentsTimer, QObject::connect(&updateVisibleButNotCurrentDocumentsTimer,
&QTimer::timeout, &QTimer::timeout,
[this]() { [this]() {
processJobsForDirtyAndVisibleButNotCurrentDocuments(); addAndRunUpdateJobs(documents.dirtyAndVisibleButNotCurrentDocuments());
}); });
QObject::connect(documents.clangFileSystemWatcher(), QObject::connect(documents.clangFileSystemWatcher(),
&ClangFileSystemWatcher::fileChanged, &ClangFileSystemWatcher::fileChanged,
[this](const Utf8String &filePath) { [this](const Utf8String &filePath) {
ClangCodeModelServer::startDocumentAnnotationsTimerIfFileIsNotOpenAsDocument(filePath); if (!documents.hasDocumentWithFilePath(filePath))
updateDocumentAnnotationsTimer.start(0);
}); });
} }
@@ -308,12 +309,6 @@ const Documents &ClangCodeModelServer::documentsForTestOnly() const
return documents; return documents;
} }
void ClangCodeModelServer::startDocumentAnnotationsTimerIfFileIsNotOpenAsDocument(const Utf8String &filePath)
{
if (!documents.hasDocumentWithFilePath(filePath))
updateDocumentAnnotationsTimer.start(0);
}
QList<Jobs::RunningJob> ClangCodeModelServer::runningJobsForTestsOnly() QList<Jobs::RunningJob> ClangCodeModelServer::runningJobsForTestsOnly()
{ {
return documentProcessors().runningJobs(); return documentProcessors().runningJobs();
@@ -375,11 +370,6 @@ void ClangCodeModelServer::processTimerForVisibleButNotCurrentDocuments()
} }
} }
void ClangCodeModelServer::processJobsForDirtyAndVisibleButNotCurrentDocuments()
{
addAndRunUpdateJobs(documents.dirtyAndVisibleButNotCurrentDocuments());
}
void ClangCodeModelServer::processSuspendResumeJobs(const std::vector<Document> &documents) void ClangCodeModelServer::processSuspendResumeJobs(const std::vector<Document> &documents)
{ {
const SuspendResumeJobs suspendResumeJobs = createSuspendResumeJobs(documents); const SuspendResumeJobs suspendResumeJobs = createSuspendResumeJobs(documents);

3
src/tools/clangbackend/source/clangcodemodelserver.h
View File

@@ -72,13 +72,10 @@ public: // for tests
DocumentProcessors &documentProcessors(); DocumentProcessors &documentProcessors();
private: private:
void startDocumentAnnotationsTimerIfFileIsNotOpenAsDocument(const Utf8String &filePath);
void processInitialJobsForDocuments(const std::vector<Document> &documents); void processInitialJobsForDocuments(const std::vector<Document> &documents);
void processJobsForDirtyAndVisibleDocuments(); void processJobsForDirtyAndVisibleDocuments();
void processJobsForDirtyCurrentDocument(); void processJobsForDirtyCurrentDocument();
void processTimerForVisibleButNotCurrentDocuments(); void processTimerForVisibleButNotCurrentDocuments();
void processJobsForDirtyAndVisibleButNotCurrentDocuments();
void processSuspendResumeJobs(const std::vector<Document> &documents); void processSuspendResumeJobs(const std::vector<Document> &documents);
void addAndRunUpdateJobs(std::vector<Document> documents); void addAndRunUpdateJobs(std::vector<Document> documents);