feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

GitClient: Make lambda non-mutable

Browse Source 
Do a copy of future interface inside the lambda body instead.

Change-Id: If84e37c62e43b815cfea0b5f60fe7fcebca63093
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2023-12-12 14:05:10 +01:00
parent b60c438f34
commit 3211fd1e43
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/git/gitclient.cpp
View File

@@ -3458,12 +3458,13 @@ QFuture<unsigned> GitClient::gitVersion() const
const bool needToRunGit = m_gitVersionForBinary != newGitBinary && !newGitBinary.isEmpty(); const bool needToRunGit = m_gitVersionForBinary != newGitBinary && !newGitBinary.isEmpty();
if (needToRunGit) { if (needToRunGit) {
auto proc = new Process(const_cast<GitClient *>(this)); auto proc = new Process(const_cast<GitClient *>(this));
connect(proc, &Process::done, this, [this, proc, fi, newGitBinary]() mutable { connect(proc, &Process::done, this, [this, proc, fi, newGitBinary] {
auto fiCopy = fi; // In order to avoid mutable lambda.
if (proc->result() == ProcessResult::FinishedWithSuccess) { if (proc->result() == ProcessResult::FinishedWithSuccess) {
m_cachedGitVersion = parseGitVersion(proc->cleanedStdOut()); m_cachedGitVersion = parseGitVersion(proc->cleanedStdOut());
m_gitVersionForBinary = newGitBinary; m_gitVersionForBinary = newGitBinary;
fi.reportResult(m_cachedGitVersion); fiCopy.reportResult(m_cachedGitVersion);
fi.reportFinished(); fiCopy.reportFinished();
} }
proc->deleteLater(); proc->deleteLater();
}); });