From 324d0f72714bda23ef1890eb499b3fd03cab9ca4 Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 5 Feb 2024 14:39:25 +0100 Subject: [PATCH] Git: Also show binary path in the settings More similar to svn, cc, bzr, and Gives the user a chance to specify something different. Plan is to make this also work with remote setups [and possibly a per-device option, or automatism] Change-Id: I18c1a90642c9cbe2ef9419103f3919c4a19122e5 Reviewed-by: Orgad Shaneh --- src/plugins/git/gitsettings.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/plugins/git/gitsettings.cpp b/src/plugins/git/gitsettings.cpp index cb23f55c9a8..43b0e8ae6c7 100644 --- a/src/plugins/git/gitsettings.cpp +++ b/src/plugins/git/gitsettings.cpp @@ -30,10 +30,13 @@ GitSettings::GitSettings() setAutoApply(false); setSettingsGroup("Git"); - path.setDisplayStyle(StringAspect::LineEditDisplay); path.setLabelText(Tr::tr("Prepend to PATH:")); + path.setDisplayStyle(StringAspect::LineEditDisplay); + binaryPath.setLabelText(Tr::tr("Git Command")); binaryPath.setDefaultValue("git"); + binaryPath.setExpectedKind(PathChooser::ExistingCommand); + binaryPath.setHistoryCompleter("Git.Command.History"); pullRebase.setSettingsKey("PullRebase"); pullRebase.setLabelText(Tr::tr("Pull with rebase")); @@ -121,8 +124,9 @@ GitSettings::GitSettings() return Column { Group { title(Tr::tr("Configuration")), - Column { - Row { path }, + Form { + binaryPath, br, + path, br, winSetHomeEnvironment, } },