From 327645c0f0d85785b2f139f3c17297aaf41605e4 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 9 Jul 2021 16:30:09 +0200 Subject: [PATCH] Remove unused readChannel() By default QProcess::readChannel() returns StandardOutput, and since no one modifies it, it will always be the same. No need for an assert. Change-Id: Id55f75e5cce4f1b8eaef2ec3094d7b103c2f0238 Reviewed-by: hjk --- src/libs/utils/qtcprocess.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/libs/utils/qtcprocess.cpp b/src/libs/utils/qtcprocess.cpp index 95efd566be5..57fdc03b915 100644 --- a/src/libs/utils/qtcprocess.cpp +++ b/src/libs/utils/qtcprocess.cpp @@ -118,7 +118,6 @@ public: virtual void setStandardInputFile(const QString &fileName) = 0; virtual void setProcessChannelMode(QProcess::ProcessChannelMode mode) = 0; - virtual QProcess::ProcessChannel readChannel() const = 0; // only in assert? virtual qint64 bytesAvailable() const = 0; virtual QString program() const = 0; virtual QProcess::ProcessError error() const = 0; @@ -230,8 +229,6 @@ public: void setProcessChannelMode(QProcess::ProcessChannelMode mode) override { m_process.setProcessChannelMode(mode); } - QProcess::ProcessChannel readChannel() const override - { return m_process.readChannel(); } qint64 bytesAvailable() const override { return m_process.bytesAvailable(); } QString program() const override @@ -307,7 +304,6 @@ public: void setStandardInputFile(const QString &fileName) override { QTC_CHECK(false); } void setProcessChannelMode(QProcess::ProcessChannelMode mode) override { QTC_CHECK(false); } - QProcess::ProcessChannel readChannel() const override { QTC_CHECK(false); return QProcess::StandardOutput; } qint64 bytesAvailable() const override { QTC_CHECK(false); return 0; } QString program() const override { return m_command; } QProcess::ProcessError error() const override { return m_error; } @@ -873,8 +869,6 @@ bool QtcProcess::readDataFromProcess(int timeoutS, return false; } - QTC_ASSERT(d->m_process->readChannel() == QProcess::StandardOutput, return false); - // Keep the process running until it has no longer has data bool finished = false; bool hasData = false;