diff --git a/src/plugins/android/androidrunconfiguration.cpp b/src/plugins/android/androidrunconfiguration.cpp index 8aff1b39ae2..1f16851fff0 100644 --- a/src/plugins/android/androidrunconfiguration.cpp +++ b/src/plugins/android/androidrunconfiguration.cpp @@ -56,10 +56,7 @@ using namespace Utils; namespace Android { -BaseStringListAspect::BaseStringListAspect(RunConfiguration *runConfig, - const QString &settingsKey, - Core::Id id) - : IRunConfigurationAspect(runConfig) +BaseStringListAspect::BaseStringListAspect(const QString &settingsKey, Core::Id id) { setSettingsKey(settingsKey); setId(id); diff --git a/src/plugins/android/androidrunconfiguration.h b/src/plugins/android/androidrunconfiguration.h index 723f935b2b0..b0beb5397cf 100644 --- a/src/plugins/android/androidrunconfiguration.h +++ b/src/plugins/android/androidrunconfiguration.h @@ -39,8 +39,7 @@ class BaseStringListAspect : public ProjectExplorer::IRunConfigurationAspect Q_OBJECT public: - explicit BaseStringListAspect(ProjectExplorer::RunConfiguration *rc, - const QString &settingsKey = QString(), + explicit BaseStringListAspect(const QString &settingsKey = QString(), Core::Id id = Core::Id()); ~BaseStringListAspect() override; diff --git a/src/plugins/android/androidrunenvironmentaspect.cpp b/src/plugins/android/androidrunenvironmentaspect.cpp index d2949de6b9d..1db75f03529 100644 --- a/src/plugins/android/androidrunenvironmentaspect.cpp +++ b/src/plugins/android/androidrunenvironmentaspect.cpp @@ -32,8 +32,7 @@ enum BaseEnvironmentBase { namespace Android { -AndroidRunEnvironmentAspect::AndroidRunEnvironmentAspect(ProjectExplorer::RunConfiguration *rc) : - ProjectExplorer::EnvironmentAspect (rc) +AndroidRunEnvironmentAspect::AndroidRunEnvironmentAspect() { addSupportedBaseEnvironment(CleanEnvironmentBase, tr("Clean Environment")); } diff --git a/src/plugins/android/androidrunenvironmentaspect.h b/src/plugins/android/androidrunenvironmentaspect.h index 2b91bfafa15..0620f577467 100644 --- a/src/plugins/android/androidrunenvironmentaspect.h +++ b/src/plugins/android/androidrunenvironmentaspect.h @@ -33,7 +33,7 @@ class AndroidRunEnvironmentAspect : public ProjectExplorer::EnvironmentAspect Q_OBJECT public: - AndroidRunEnvironmentAspect(ProjectExplorer::RunConfiguration *rc); + AndroidRunEnvironmentAspect(); Utils::Environment baseEnvironment() const override; }; diff --git a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp index 402151df74f..cb618e06579 100644 --- a/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp +++ b/src/plugins/cmakeprojectmanager/cmakerunconfiguration.cpp @@ -53,7 +53,7 @@ CMakeRunConfiguration::CMakeRunConfiguration(Target *target, Core::Id id) if (qt) env.prependOrSetPath(qt->qmakeProperty("QT_INSTALL_BINS")); }; - auto envAspect = addAspect(cmakeRunEnvironmentModifier); + auto envAspect = addAspect(target, cmakeRunEnvironmentModifier); addAspect(); addAspect(); diff --git a/src/plugins/debugger/debuggerrunconfigurationaspect.cpp b/src/plugins/debugger/debuggerrunconfigurationaspect.cpp index 764e885ac22..93c109df0c5 100644 --- a/src/plugins/debugger/debuggerrunconfigurationaspect.cpp +++ b/src/plugins/debugger/debuggerrunconfigurationaspect.cpp @@ -208,9 +208,8 @@ void DebuggerRunConfigWidget::useMultiProcessToggled(bool on) \class Debugger::DebuggerRunConfigurationAspect */ -DebuggerRunConfigurationAspect::DebuggerRunConfigurationAspect( - RunConfiguration *rc) : - IRunConfigurationAspect(rc), m_target(rc->target()) +DebuggerRunConfigurationAspect::DebuggerRunConfigurationAspect(RunConfiguration *rc) + : m_target(rc->target()) { setId("DebuggerAspect"); setDisplayName(tr("Debugger settings")); diff --git a/src/plugins/nim/project/nimrunconfiguration.cpp b/src/plugins/nim/project/nimrunconfiguration.cpp index dd94f3fddee..21c6d50779f 100644 --- a/src/plugins/nim/project/nimrunconfiguration.cpp +++ b/src/plugins/nim/project/nimrunconfiguration.cpp @@ -44,7 +44,8 @@ namespace Nim { NimRunConfiguration::NimRunConfiguration(Target *target, Core::Id id) : RunConfiguration(target, id) { - auto envAspect = addAspect(LocalEnvironmentAspect::BaseEnvironmentModifier()); + auto envAspect = addAspect + (target, LocalEnvironmentAspect::BaseEnvironmentModifier()); addAspect(); addAspect(); diff --git a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp index c255c063be5..89e511a192d 100644 --- a/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp +++ b/src/plugins/projectexplorer/customexecutablerunconfiguration.cpp @@ -87,9 +87,7 @@ private: CustomExecutableDialog::CustomExecutableDialog(RunConfiguration *rc) : QDialog(Core::ICore::dialogParent()), m_rc(rc), - m_arguments(rc), - m_workingDirectory(rc, rc->extraAspect()), - m_terminal(rc) + m_workingDirectory(rc->extraAspect()) { auto vbox = new QVBoxLayout(this); vbox->addWidget(new QLabel(tr("Could not find the executable, please specify one."))); @@ -178,7 +176,8 @@ CustomExecutableRunConfiguration::CustomExecutableRunConfiguration(Target *targe CustomExecutableRunConfiguration::CustomExecutableRunConfiguration(Target *target, Core::Id id) : RunConfiguration(target, id) { - auto envAspect = addAspect(LocalEnvironmentAspect::BaseEnvironmentModifier()); + auto envAspect = addAspect + (target, LocalEnvironmentAspect::BaseEnvironmentModifier()); auto exeAspect = addAspect(); exeAspect->setSettingsKey("ProjectExplorer.CustomExecutableRunConfiguration.Executable"); diff --git a/src/plugins/projectexplorer/environmentaspect.cpp b/src/plugins/projectexplorer/environmentaspect.cpp index 02f36d8120f..d0b0845a3e2 100644 --- a/src/plugins/projectexplorer/environmentaspect.cpp +++ b/src/plugins/projectexplorer/environmentaspect.cpp @@ -39,8 +39,7 @@ namespace ProjectExplorer { // EnvironmentAspect: // -------------------------------------------------------------------- -EnvironmentAspect::EnvironmentAspect(RunConfiguration *runConfig) : - IRunConfigurationAspect(runConfig) +EnvironmentAspect::EnvironmentAspect() { setDisplayName(tr("Run Environment")); setId("EnvironmentAspect"); diff --git a/src/plugins/projectexplorer/environmentaspect.h b/src/plugins/projectexplorer/environmentaspect.h index 544629b4d43..7b0ff4be7eb 100644 --- a/src/plugins/projectexplorer/environmentaspect.h +++ b/src/plugins/projectexplorer/environmentaspect.h @@ -64,7 +64,7 @@ signals: void environmentChanged(); protected: - explicit EnvironmentAspect(RunConfiguration *rc); + EnvironmentAspect(); void fromMap(const QVariantMap &map) override; void toMap(QVariantMap &map) const override; diff --git a/src/plugins/projectexplorer/localenvironmentaspect.cpp b/src/plugins/projectexplorer/localenvironmentaspect.cpp index c07cbe5eb12..2a6eee97c5a 100644 --- a/src/plugins/projectexplorer/localenvironmentaspect.cpp +++ b/src/plugins/projectexplorer/localenvironmentaspect.cpp @@ -67,11 +67,10 @@ void LocalEnvironmentAspect::buildEnvironmentHasChanged() emit environmentChanged(); } -LocalEnvironmentAspect::LocalEnvironmentAspect(RunConfiguration *parent, +LocalEnvironmentAspect::LocalEnvironmentAspect(Target *target, const BaseEnvironmentModifier &modifier) : - EnvironmentAspect(parent), m_baseEnvironmentModifier(modifier), - m_target(parent->target()) + m_target(target) { addPreferredBaseEnvironment(BuildEnvironmentBase, tr("Build Environment")); addSupportedBaseEnvironment(SystemEnvironmentBase, tr("System Environment")); diff --git a/src/plugins/projectexplorer/localenvironmentaspect.h b/src/plugins/projectexplorer/localenvironmentaspect.h index 53c7b617551..d8424b41ea2 100644 --- a/src/plugins/projectexplorer/localenvironmentaspect.h +++ b/src/plugins/projectexplorer/localenvironmentaspect.h @@ -35,7 +35,7 @@ class PROJECTEXPLORER_EXPORT LocalEnvironmentAspect : public EnvironmentAspect public: typedef std::function BaseEnvironmentModifier; - LocalEnvironmentAspect(RunConfiguration *parent, const BaseEnvironmentModifier &modifier); + LocalEnvironmentAspect(Target *parent, const BaseEnvironmentModifier &modifier); Utils::Environment baseEnvironment() const override; diff --git a/src/plugins/projectexplorer/runconfiguration.cpp b/src/plugins/projectexplorer/runconfiguration.cpp index 96072b4f0f4..d39f7d06a4f 100644 --- a/src/plugins/projectexplorer/runconfiguration.cpp +++ b/src/plugins/projectexplorer/runconfiguration.cpp @@ -93,9 +93,7 @@ QWidget *ISettingsAspect::createConfigWidget() const // /////////////////////////////////////////////////////////////////////// -IRunConfigurationAspect::IRunConfigurationAspect(RunConfiguration *runConfig) : - m_runConfiguration(runConfig) -{ } +IRunConfigurationAspect::IRunConfigurationAspect() = default; IRunConfigurationAspect::~IRunConfigurationAspect() { diff --git a/src/plugins/projectexplorer/runconfiguration.h b/src/plugins/projectexplorer/runconfiguration.h index 25687474665..55cf9e504bd 100644 --- a/src/plugins/projectexplorer/runconfiguration.h +++ b/src/plugins/projectexplorer/runconfiguration.h @@ -107,7 +107,7 @@ class PROJECTEXPLORER_EXPORT IRunConfigurationAspect : public QObject Q_OBJECT public: - explicit IRunConfigurationAspect(RunConfiguration *runConfig); + IRunConfigurationAspect(); ~IRunConfigurationAspect() override; using ConfigWidgetCreator = std::function; @@ -132,7 +132,6 @@ public: ISettingsAspect *projectSettings() const { return m_projectSettings; } ISettingsAspect *globalSettings() const { return m_globalSettings; } ISettingsAspect *currentSettings() const; - RunConfiguration *runConfiguration() const { return m_runConfiguration; } virtual void addToConfigurationLayout(QFormLayout *layout); @@ -150,7 +149,6 @@ private: QString m_settingsKey; // Name of data in settings. bool m_useGlobalSettings = false; bool m_visible = true; - RunConfiguration *m_runConfiguration = nullptr; ISettingsAspect *m_projectSettings = nullptr; // Owned if present. ISettingsAspect *m_globalSettings = nullptr; // Not owned. ConfigWidgetCreator m_configWidgetCreator; @@ -222,7 +220,7 @@ public: template Aspect *addAspect(Args && ...args) { - auto aspect = new Aspect(this, args...); + auto aspect = new Aspect(args...); m_aspects.append(aspect); return aspect; } diff --git a/src/plugins/projectexplorer/runconfigurationaspects.cpp b/src/plugins/projectexplorer/runconfigurationaspects.cpp index eb272ad38d5..bdad95fdc1c 100644 --- a/src/plugins/projectexplorer/runconfigurationaspects.cpp +++ b/src/plugins/projectexplorer/runconfigurationaspects.cpp @@ -51,8 +51,7 @@ namespace ProjectExplorer { \class ProjectExplorer::TerminalAspect */ -TerminalAspect::TerminalAspect(RunConfiguration *runConfig, bool useTerminal) : - IRunConfigurationAspect(runConfig), m_useTerminal(useTerminal) +TerminalAspect::TerminalAspect() { setDisplayName(tr("Terminal")); setId("TerminalAspect"); @@ -115,10 +114,8 @@ bool TerminalAspect::isUserSet() const \class ProjectExplorer::WorkingDirectoryAspect */ -WorkingDirectoryAspect::WorkingDirectoryAspect(RunConfiguration *runConfig, - EnvironmentAspect *envAspect) - : IRunConfigurationAspect(runConfig), - m_envAspect(envAspect) +WorkingDirectoryAspect::WorkingDirectoryAspect(EnvironmentAspect *envAspect) + : m_envAspect(envAspect) { setDisplayName(tr("Working Directory")); setId("WorkingDirectoryAspect"); @@ -237,8 +234,7 @@ PathChooser *WorkingDirectoryAspect::pathChooser() const \class ProjectExplorer::ArgumentsAspect */ -ArgumentsAspect::ArgumentsAspect(RunConfiguration *runConfig) - : IRunConfigurationAspect(runConfig) +ArgumentsAspect::ArgumentsAspect() { setDisplayName(tr("Arguments")); setId("ArgumentsAspect"); @@ -300,10 +296,7 @@ void ArgumentsAspect::addToConfigurationLayout(QFormLayout *layout) \class ProjectExplorer::BaseStringAspect */ -BaseStringAspect::BaseStringAspect(RunConfiguration *rc) - : IRunConfigurationAspect(rc) -{ -} +BaseStringAspect::BaseStringAspect() = default; BaseStringAspect::~BaseStringAspect() { @@ -486,7 +479,7 @@ void BaseStringAspect::update() void BaseStringAspect::makeCheckable(const QString &checkerLabel, const QString &checkerKey) { QTC_ASSERT(!m_checker, return); - m_checker = new BaseBoolAspect(runConfiguration()); + m_checker = new BaseBoolAspect; m_checker->setLabel(checkerLabel); m_checker->setSettingsKey(checkerKey); @@ -500,8 +493,7 @@ void BaseStringAspect::makeCheckable(const QString &checkerLabel, const QString \class ProjectExplorer::ExecutableAspect */ -ExecutableAspect::ExecutableAspect(RunConfiguration *rc) - : IRunConfigurationAspect(rc), m_executable(rc) +ExecutableAspect::ExecutableAspect() { setDisplayName(tr("Executable")); setId("ExecutableAspect"); @@ -556,7 +548,7 @@ void ExecutableAspect::setDisplayStyle(BaseStringAspect::DisplayStyle style) void ExecutableAspect::makeOverridable(const QString &overridingKey, const QString &useOverridableKey) { QTC_ASSERT(!m_alternativeExecutable, return); - m_alternativeExecutable = new BaseStringAspect(runConfiguration()); + m_alternativeExecutable = new BaseStringAspect; m_alternativeExecutable->setDisplayStyle(BaseStringAspect::LineEditDisplay); m_alternativeExecutable->setLabelText(tr("Alternate executable on device:")); m_alternativeExecutable->setSettingsKey(overridingKey); @@ -619,8 +611,7 @@ void ExecutableAspect::toMap(QVariantMap &map) const \class ProjectExplorer::BaseBoolAspect */ -BaseBoolAspect::BaseBoolAspect(RunConfiguration *runConfig, const QString &settingsKey) - : IRunConfigurationAspect(runConfig) +BaseBoolAspect::BaseBoolAspect(const QString &settingsKey) { setSettingsKey(settingsKey); } @@ -670,8 +661,7 @@ void BaseBoolAspect::setLabel(const QString &label) \class ProjectExplorer::UseLibraryPathsAspect */ -UseLibraryPathsAspect::UseLibraryPathsAspect(RunConfiguration *rc) - : BaseBoolAspect(rc) +UseLibraryPathsAspect::UseLibraryPathsAspect() { setId("UseLibraryPath"); setSettingsKey("RunConfiguration.UseLibrarySearchPath"); @@ -688,8 +678,7 @@ UseLibraryPathsAspect::UseLibraryPathsAspect(RunConfiguration *rc) \class ProjectExplorer::UseDyldSuffixAspect */ -UseDyldSuffixAspect::UseDyldSuffixAspect(RunConfiguration *rc) - : BaseBoolAspect(rc) +UseDyldSuffixAspect::UseDyldSuffixAspect() { setId("UseDyldSuffix"); setSettingsKey("RunConfiguration.UseDyldImageSuffix"); diff --git a/src/plugins/projectexplorer/runconfigurationaspects.h b/src/plugins/projectexplorer/runconfigurationaspects.h index 50ecf57e98c..651b1933eff 100644 --- a/src/plugins/projectexplorer/runconfigurationaspects.h +++ b/src/plugins/projectexplorer/runconfigurationaspects.h @@ -48,7 +48,7 @@ class PROJECTEXPLORER_EXPORT TerminalAspect : public IRunConfigurationAspect Q_OBJECT public: - TerminalAspect(RunConfiguration *rc, bool useTerminal = false); + TerminalAspect(); void addToConfigurationLayout(QFormLayout *layout) override; @@ -71,8 +71,7 @@ class PROJECTEXPLORER_EXPORT WorkingDirectoryAspect : public IRunConfigurationAs Q_OBJECT public: - WorkingDirectoryAspect(RunConfiguration *runConfig, - EnvironmentAspect *envAspect = nullptr); + explicit WorkingDirectoryAspect(EnvironmentAspect *envAspect = nullptr); void addToConfigurationLayout(QFormLayout *layout) override; @@ -101,7 +100,7 @@ class PROJECTEXPLORER_EXPORT ArgumentsAspect : public IRunConfigurationAspect Q_OBJECT public: - explicit ArgumentsAspect(RunConfiguration *runConfig); + ArgumentsAspect(); void addToConfigurationLayout(QFormLayout *layout) override; @@ -126,7 +125,7 @@ class PROJECTEXPLORER_EXPORT BaseBoolAspect : public IRunConfigurationAspect Q_OBJECT public: - explicit BaseBoolAspect(RunConfiguration *rc, const QString &settingsKey = QString()); + explicit BaseBoolAspect(const QString &settingsKey = QString()); ~BaseBoolAspect() override; void addToConfigurationLayout(QFormLayout *layout) override; @@ -150,7 +149,7 @@ class PROJECTEXPLORER_EXPORT UseLibraryPathsAspect : public BaseBoolAspect Q_OBJECT public: - explicit UseLibraryPathsAspect(RunConfiguration *rc); + UseLibraryPathsAspect(); }; class PROJECTEXPLORER_EXPORT UseDyldSuffixAspect : public BaseBoolAspect @@ -158,7 +157,7 @@ class PROJECTEXPLORER_EXPORT UseDyldSuffixAspect : public BaseBoolAspect Q_OBJECT public: - explicit UseDyldSuffixAspect(RunConfiguration *rc); + UseDyldSuffixAspect(); }; class PROJECTEXPLORER_EXPORT BaseStringAspect : public IRunConfigurationAspect @@ -166,7 +165,7 @@ class PROJECTEXPLORER_EXPORT BaseStringAspect : public IRunConfigurationAspect Q_OBJECT public: - explicit BaseStringAspect(RunConfiguration *rc); + BaseStringAspect(); ~BaseStringAspect() override; void addToConfigurationLayout(QFormLayout *layout) override; @@ -221,7 +220,7 @@ class PROJECTEXPLORER_EXPORT ExecutableAspect : public IRunConfigurationAspect Q_OBJECT public: - explicit ExecutableAspect(RunConfiguration *rc); + ExecutableAspect(); ~ExecutableAspect() override; Utils::FileName executable() const; @@ -254,7 +253,7 @@ class PROJECTEXPLORER_EXPORT SymbolFileAspect : public BaseStringAspect Q_OBJECT public: - SymbolFileAspect(RunConfiguration *rc) : BaseStringAspect(rc) {} + SymbolFileAspect() = default; }; } // namespace ProjectExplorer diff --git a/src/plugins/pythoneditor/pythoneditorplugin.cpp b/src/plugins/pythoneditor/pythoneditorplugin.cpp index 0b5b69797a4..f728f6bbc65 100644 --- a/src/plugins/pythoneditor/pythoneditorplugin.cpp +++ b/src/plugins/pythoneditor/pythoneditorplugin.cpp @@ -209,7 +209,7 @@ class InterpreterAspect : public BaseStringAspect Q_OBJECT public: - explicit InterpreterAspect(RunConfiguration *rc) : BaseStringAspect(rc) {} + InterpreterAspect() = default; }; class MainScriptAspect : public BaseStringAspect @@ -217,7 +217,7 @@ class MainScriptAspect : public BaseStringAspect Q_OBJECT public: - explicit MainScriptAspect(RunConfiguration *rc) : BaseStringAspect(rc) {} + MainScriptAspect() = default; }; class PythonRunConfiguration : public RunConfiguration @@ -262,7 +262,7 @@ PythonRunConfiguration::PythonRunConfiguration(Target *target, Core::Id id) scriptAspect->setLabelText(tr("Script:")); scriptAspect->setDisplayStyle(BaseStringAspect::LabelDisplay); - addAspect(LocalEnvironmentAspect::BaseEnvironmentModifier()); + addAspect(target, LocalEnvironmentAspect::BaseEnvironmentModifier()); addAspect(); addAspect(); diff --git a/src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp b/src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp index bd1e3ceaaeb..a28257d36fe 100644 --- a/src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp +++ b/src/plugins/qbsprojectmanager/qbsrunconfiguration.cpp @@ -52,7 +52,7 @@ namespace Internal { QbsRunConfiguration::QbsRunConfiguration(Target *target, Core::Id id) : RunConfiguration(target, id) { - auto envAspect = addAspect( + auto envAspect = addAspect(target, [this](Environment &env) { addToBaseEnvironment(env); }); addAspect(); diff --git a/src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp b/src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp index f6cbac8e8f0..b58807d5bf5 100644 --- a/src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp +++ b/src/plugins/qmakeprojectmanager/desktopqmakerunconfiguration.cpp @@ -63,7 +63,7 @@ const char PRO_FILE_KEY[] = "Qt4ProjectManager.Qt4RunConfiguration.ProFile"; DesktopQmakeRunConfiguration::DesktopQmakeRunConfiguration(Target *target, Core::Id id) : RunConfiguration(target, id) { - auto envAspect = addAspect([this](Environment &env) { + auto envAspect = addAspect(target, [this](Environment &env) { addToBaseEnvironment(env); }); diff --git a/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.cpp b/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.cpp index 33e75ab3217..352423c891b 100644 --- a/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.cpp @@ -34,8 +34,7 @@ namespace QmlProfiler { namespace Internal { QmlProfilerRunConfigurationAspect::QmlProfilerRunConfigurationAspect( - ProjectExplorer::RunConfiguration *parent) : - ProjectExplorer::IRunConfigurationAspect(parent) + ProjectExplorer::RunConfiguration *) { setProjectSettings(new QmlProfilerSettings); setGlobalSettings(QmlProfilerPlugin::globalSettings()); diff --git a/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.h b/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.h index efdf4a7a41d..308fb6e3a0b 100644 --- a/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.h +++ b/src/plugins/qmlprofiler/qmlprofilerrunconfigurationaspect.h @@ -33,7 +33,7 @@ namespace Internal { class QmlProfilerRunConfigurationAspect : public ProjectExplorer::IRunConfigurationAspect { public: - QmlProfilerRunConfigurationAspect(ProjectExplorer::RunConfiguration *parent); + QmlProfilerRunConfigurationAspect(ProjectExplorer::RunConfiguration *); }; } // Internal diff --git a/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.cpp b/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.cpp index eca30dc283c..8c85c0553ea 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.cpp @@ -53,8 +53,8 @@ Environment QmlProjectEnvironmentAspect::baseEnvironment() const return env; } -QmlProjectEnvironmentAspect::QmlProjectEnvironmentAspect(RunConfiguration *rc, Target *target) - : EnvironmentAspect(rc), m_target(target) +QmlProjectEnvironmentAspect::QmlProjectEnvironmentAspect(Target *target) + : m_target(target) { if (DeviceTypeKitInformation::deviceTypeId(target->kit()) == Constants::DESKTOP_DEVICE_TYPE) diff --git a/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.h b/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.h index 2d455ee10bf..65880649fba 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.h +++ b/src/plugins/qmlprojectmanager/qmlprojectenvironmentaspect.h @@ -34,8 +34,7 @@ class QmlProjectEnvironmentAspect : public ProjectExplorer::EnvironmentAspect Q_OBJECT public: - QmlProjectEnvironmentAspect(ProjectExplorer::RunConfiguration *rc, - ProjectExplorer::Target *target); + QmlProjectEnvironmentAspect(ProjectExplorer::Target *target); Utils::Environment baseEnvironment() const override; diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp index 696f2ae821c..e59ac1c0812 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp @@ -71,7 +71,7 @@ static bool caseInsensitiveLessThan(const QString &s1, const QString &s2) class MainQmlFileAspect : public IRunConfigurationAspect { public: - MainQmlFileAspect(RunConfiguration *rc, QmlProject *project); + explicit MainQmlFileAspect(QmlProject *project); ~MainQmlFileAspect() { delete m_fileListCombo; } enum MainScriptSource { @@ -105,8 +105,8 @@ public: QString m_mainScriptFilename; }; -MainQmlFileAspect::MainQmlFileAspect(RunConfiguration *rc, QmlProject *project) - : IRunConfigurationAspect(rc), m_project(project) +MainQmlFileAspect::MainQmlFileAspect(QmlProject *project) + : m_project(project) { m_scriptFile = M_CURRENT_FILE; diff --git a/src/plugins/qnx/qnxrunconfiguration.h b/src/plugins/qnx/qnxrunconfiguration.h index de0e96a7bd7..390224d1205 100644 --- a/src/plugins/qnx/qnxrunconfiguration.h +++ b/src/plugins/qnx/qnxrunconfiguration.h @@ -36,7 +36,7 @@ class QtLibPathAspect : public ProjectExplorer::BaseStringAspect Q_OBJECT public: - QtLibPathAspect(ProjectExplorer::RunConfiguration *rc) : BaseStringAspect(rc) {} + QtLibPathAspect() = default; }; class QnxRunConfiguration : public RemoteLinux::RemoteLinuxRunConfiguration diff --git a/src/plugins/remotelinux/remotelinuxcustomrunconfiguration.cpp b/src/plugins/remotelinux/remotelinuxcustomrunconfiguration.cpp index 232b6e97024..83f378ab8e2 100644 --- a/src/plugins/remotelinux/remotelinuxcustomrunconfiguration.cpp +++ b/src/plugins/remotelinux/remotelinuxcustomrunconfiguration.cpp @@ -57,7 +57,7 @@ RemoteLinuxCustomRunConfiguration::RemoteLinuxCustomRunConfiguration(Target *tar addAspect(); addAspect(); - addAspect(); + addAspect(target); setDefaultDisplayName(runConfigDefaultDisplayName()); setOutputFormatter(); diff --git a/src/plugins/remotelinux/remotelinuxenvironmentaspect.cpp b/src/plugins/remotelinux/remotelinuxenvironmentaspect.cpp index ccc4670b5ee..9d23f80fb19 100644 --- a/src/plugins/remotelinux/remotelinuxenvironmentaspect.cpp +++ b/src/plugins/remotelinux/remotelinuxenvironmentaspect.cpp @@ -47,14 +47,13 @@ enum BaseEnvironmentBase { }; -RemoteLinuxEnvironmentAspect::RemoteLinuxEnvironmentAspect(ProjectExplorer::RunConfiguration *rc) : - ProjectExplorer::EnvironmentAspect(rc) +RemoteLinuxEnvironmentAspect::RemoteLinuxEnvironmentAspect(ProjectExplorer::Target *target) { addSupportedBaseEnvironment(CleanBaseEnvironment, tr("Clean Environment")); addPreferredBaseEnvironment(RemoteBaseEnvironment, tr("System Environment")); - setConfigWidgetCreator([this, rc] { - return new RemoteLinuxEnvironmentAspectWidget(this, rc->target()); + setConfigWidgetCreator([this, target] { + return new RemoteLinuxEnvironmentAspectWidget(this, target); }); } diff --git a/src/plugins/remotelinux/remotelinuxenvironmentaspect.h b/src/plugins/remotelinux/remotelinuxenvironmentaspect.h index 5f20e3d4a35..0ac83cd4281 100644 --- a/src/plugins/remotelinux/remotelinuxenvironmentaspect.h +++ b/src/plugins/remotelinux/remotelinuxenvironmentaspect.h @@ -36,7 +36,7 @@ class REMOTELINUX_EXPORT RemoteLinuxEnvironmentAspect : public ProjectExplorer:: Q_OBJECT public: - RemoteLinuxEnvironmentAspect(ProjectExplorer::RunConfiguration *rc); + RemoteLinuxEnvironmentAspect(ProjectExplorer::Target *target); Utils::Environment baseEnvironment() const override; diff --git a/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp b/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp index b03d7dff3b5..7a799bf4298 100644 --- a/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp +++ b/src/plugins/remotelinux/remotelinuxrunconfiguration.cpp @@ -59,7 +59,7 @@ RemoteLinuxRunConfiguration::RemoteLinuxRunConfiguration(Target *target, Core::I addAspect(); addAspect(); - addAspect(); + addAspect(target); setOutputFormatter(); diff --git a/src/plugins/valgrind/valgrindplugin.cpp b/src/plugins/valgrind/valgrindplugin.cpp index 12b377481be..9a4158b0811 100644 --- a/src/plugins/valgrind/valgrindplugin.cpp +++ b/src/plugins/valgrind/valgrindplugin.cpp @@ -92,8 +92,7 @@ private: class ValgrindRunConfigurationAspect : public IRunConfigurationAspect { public: - ValgrindRunConfigurationAspect(RunConfiguration *parent) - : IRunConfigurationAspect(parent) + ValgrindRunConfigurationAspect(RunConfiguration *) { setProjectSettings(new ValgrindProjectSettings); setGlobalSettings(ValgrindPlugin::globalSettings()); diff --git a/src/plugins/winrt/winrtrunconfiguration.cpp b/src/plugins/winrt/winrtrunconfiguration.cpp index 08c912ce18b..8950a0ddea5 100644 --- a/src/plugins/winrt/winrtrunconfiguration.cpp +++ b/src/plugins/winrt/winrtrunconfiguration.cpp @@ -33,8 +33,8 @@ namespace Internal { // UninstallAfterStopAspect -UninstallAfterStopAspect::UninstallAfterStopAspect(RunConfiguration *rc) - : BaseBoolAspect(rc, "WinRtRunConfigurationUninstallAfterStopId") +UninstallAfterStopAspect::UninstallAfterStopAspect() + : BaseBoolAspect("WinRtRunConfigurationUninstallAfterStopId") { setLabel(WinRtRunConfiguration::tr("Uninstall package after application stops")); } diff --git a/src/plugins/winrt/winrtrunconfiguration.h b/src/plugins/winrt/winrtrunconfiguration.h index 76241d86703..08be96f2b6e 100644 --- a/src/plugins/winrt/winrtrunconfiguration.h +++ b/src/plugins/winrt/winrtrunconfiguration.h @@ -35,7 +35,7 @@ class UninstallAfterStopAspect : public ProjectExplorer::BaseBoolAspect Q_OBJECT public: - UninstallAfterStopAspect(ProjectExplorer::RunConfiguration *rc); + UninstallAfterStopAspect(); }; class WinRtRunConfiguration : public ProjectExplorer::RunConfiguration