From 32c389a5562cd8d5b8d66e88e59eef1e00f95425 Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Mon, 11 Dec 2023 18:25:45 +0100 Subject: [PATCH] CMakePM: Do not reconfigure during build On Windows upon a CMake file change and save during a build, the reconfiguration would fail due to the inability to save the build.ninja file. Fixes: QTCREATORBUG-30048 Change-Id: I68bec70b0a95bc4256b736a1c4caf1b4d706e43b Reviewed-by: Eike Ziller Reviewed-by: --- src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp index 6f7461799bd..4c93e3150d9 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp @@ -26,6 +26,7 @@ #include #include +#include #include #include #include @@ -1299,7 +1300,8 @@ void CMakeBuildSystem::wireUpConnections() }); connect(project(), &Project::projectFileIsDirty, this, [this] { - if (buildConfiguration()->isActive() && !isParsing()) { + const bool isBuilding = BuildManager::isBuilding(project()); + if (buildConfiguration()->isActive() && !isParsing() && !isBuilding) { if (settings().autorunCMake()) { qCDebug(cmakeBuildSystemLog) << "Requesting parse due to dirty project file"; reparse(CMakeBuildSystem::REPARSE_FORCE_CMAKE_RUN);