feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: do not create empty function hint proposal model

Browse Source 
Fixes:
SOFT ASSERT: "d->m_totalHints != 0" in functionhintproposalwidget.cpp

Change-Id: Ibfda27bf1e02b60d624851995ce1f5f54f662182
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2020-05-13 15:18:38 +02:00
parent 98be9d4f6d
commit 32d29f5a11
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/languageclient/languageclientfunctionhint.cpp
View File

@@ -106,10 +106,14 @@ void FunctionHintProcessor::handleSignatureResponse(const SignatureHelpRequest::
m_currentRequest = MessageId();
if (auto error = response.error())
m_client->log(error.value());
FunctionHintProposalModelPtr model(
new FunctionHintProposalModel(response.result().value().value()));
m_client->removeAssistProcessor(this);
setAsyncProposalAvailable(new FunctionHintProposal(m_pos, model));
const SignatureHelp &signatureHelp = response.result().value().value();
if (signatureHelp.signatures().isEmpty()) {
setAsyncProposalAvailable(nullptr);
} else {
FunctionHintProposalModelPtr model(new FunctionHintProposalModel(signatureHelp));
setAsyncProposalAvailable(new FunctionHintProposal(m_pos, model));
}
}
FunctionHintAssistProvider::FunctionHintAssistProvider(Client *client)