feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Make (and return) more properties as const-ref in McuPackage

Browse Source 
This implies that those properties are now passed into the constructor,
and their setters are removed.

Change-Id: I34b4d9d7450897e6a7a72b8edaffdc05961546d1
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: <piotr.mucko@qt.io>
This commit is contained in:
Erik Verbruggen
2022-02-01 16:07:50 +01:00
committed by piotr.mucko
parent 6b6b35f59e
commit 32f8ed7b66
5 changed files with 89 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/mcusupport/mcusupportoptions.cpp
View File

@@ -269,7 +269,7 @@ McuTarget::McuTarget(const QVersionNumber &qulVersion,
{
}
QVector<McuPackage *> McuTarget::packages() const
const QVector<McuPackage *> &McuTarget::packages() const
{
return m_packages;
}
@@ -284,7 +284,7 @@ McuTarget::OS McuTarget::os() const
return m_os;
}
McuTarget::Platform McuTarget::platform() const
const McuTarget::Platform &McuTarget::platform() const
{
return m_platform;
}
@@ -316,7 +316,7 @@ void McuTarget::printPackageProblems() const
}
}
QVersionNumber McuTarget::qulVersion() const
const QVersionNumber &McuTarget::qulVersion() const
{
return m_qulVersion;
}