feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FakeVim: Differentiate between <S-SPACE> and <SPACE> and others

Browse Source 
Since some keys with shift modifier pressed generate same string (e.g.
<S-SPACE> and <SPACE>), the modifier must not be ignored.

Recognize Qt::Key_Backtab as <S-TAB>.

Change-Id: I6b25dec4b3bc9564249609449f9df7cd7fab263e
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
hluk
2014-02-09 13:20:27 +01:00
committed by hjk
parent a64c401029
commit 33345045bc
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/fakevim/fakevimhandler.cpp
View File

@@ -939,7 +939,7 @@ public:
// cursor keys. This breaks some of the logic later on
// relying on text() being empty for "special" keys.
// FIXME: Check the real conditions.
if (x.unicode() < ' ')
if (x.unicode() <= ' ')
m_text.clear();
else if (x.isLetter())
m_key = x.toUpper().unicode();
@@ -948,7 +948,16 @@ public:
// Set text only if input is ascii key without control modifier.
if (m_text.isEmpty() && k >= 0 && k <= 0x7f && (m & HostOsInfo::controlModifier()) == 0) {
QChar c = QChar::fromLatin1(k);
m_text = QString((m & ShiftModifier) != 0 ? c.toUpper() : c.toLower());
if (c.isLetter())
m_text = QString(isShift() ? c.toUpper() : c);
else if (!isShift())
m_text = c;
}
// Normalize <S-TAB>.
if (m_key == Qt::Key_Backtab) {
m_key = Qt::Key_Tab;
m_modifiers |= Qt::ShiftModifier;
}
// m_xkey is only a cache.